From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>
Subject: RE: [PATCH] net: renesas: ravb: Fix a stuck issue when a lot of frames are received
Date: Mon, 17 May 2021 08:23:07 +0000 [thread overview]
Message-ID: <TY2PR01MB3692C8684B5AC4EAC10A1785D82D9@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TY2PR01MB369211466F9F6DB5EDC41183D8549@TY2PR01MB3692.jpnprd01.prod.outlook.com>
Hi again,
> From: Yoshihiro Shimoda, Sent: Monday, May 10, 2021 7:30 PM
>
> > From: Sergei Shtylyov, Sent: Sunday, May 9, 2021 7:22 PM
> >
> > On 08.05.2021 23:47, Sergei Shtylyov wrote:
> >
> > > Posting a review of the already commited (over my head) patch. It would have
> > > been appropriate if the patch looked OK but it's not. :-/
> > >
> > >> When a lot of frames were received in the short term, the driver
> > >> caused a stuck of receiving until a new frame was received. For example,
> > >> the following command from other device could cause this issue.
> > >>
> > >> $ sudo ping -f -l 1000 -c 1000 <this driver's ipaddress>
> > >
> > > -l is essential here, right?
>
> Yes.
>
> > > Have you tried testing sh_eth sriver like that, BTW?
> >
> > It's driver! :-)
>
> I have not tried testing sh_eth driver yet. I'll test it after I got an actual board.
I could reproduce a similar issue on R-Car Gen2 with sh_eth driver if the RX ring size is 1024 like
the ravb driver. Also, I confirmed a similar patch for sh_eth driver could fix the issue.
So, I'll send a patch later.
Best regards,
Yoshihiro Shimoda
> > >> The previous code always cleared the interrupt flag of RX but checks
> > >> the interrupt flags in ravb_poll(). So, ravb_poll() could not call
> > >> ravb_rx() in the next time until a new RX frame was received if
> > >> ravb_rx() returned true. To fix the issue, always calls ravb_rx()
> > >> regardless the interrupt flags condition.
> > >
> > > That bacially defeats the purpose of IIUC...
> > ^ NAPI,
> >
> > I was sure I typed NAPI here, yet it got lost in the edits. :-)
>
> I could not understand "that" (calling ravb_rx() regardless the interrupt
> flags condition) defeats the purpose of NAPI. According to an article on
> the Linux Foundation wiki [1], one of the purpose of NAPI is "Interrupt mitigation".
> In poll(), the interrupts are already disabled, and ravb_rx() will check the
> descriptor's status. So, this patch keeps the "Interrupt mitigation" IIUC.
>
> [1]
> https://wiki.linuxfoundation.org/networking/napi
>
> Best regards,
> Yoshihiro Shimoda
next prev parent reply other threads:[~2021-05-17 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 4:52 [PATCH] net: renesas: ravb: Fix a stuck issue when a lot of frames are received Yoshihiro Shimoda
2021-04-21 18:00 ` patchwork-bot+netdevbpf
2021-04-21 18:14 ` Sergei Shtylyov
2021-04-21 18:20 ` David Miller
2021-05-05 19:00 ` Sergei Shtylyov
2021-05-05 20:09 ` Sergei Shtylyov
2021-05-08 20:47 ` Sergei Shtylyov
2021-05-09 10:21 ` Sergei Shtylyov
2021-05-10 10:29 ` Yoshihiro Shimoda
2021-05-17 8:23 ` Yoshihiro Shimoda [this message]
2021-05-17 19:35 ` Sergei Shtylyov
2021-05-18 2:20 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY2PR01MB3692C8684B5AC4EAC10A1785D82D9@TY2PR01MB3692.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).