From: "Y.b. Lu" <yangbo.lu@nxp.com>
To: "Allan W. Nielsen" <allan.nielsen@microchip.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH 3/3] ocelot_ace: fix action of trap
Date: Wed, 14 Aug 2019 04:03:20 +0000 [thread overview]
Message-ID: <VI1PR0401MB223711A1DB199D1C3CCFD9CCF8AD0@VI1PR0401MB2237.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190813061603.7ippfny5ce6iee2z@lx-anielsen.microsemi.net>
Hi Allan,
> -----Original Message-----
> From: Allan W. Nielsen <allan.nielsen@microchip.com>
> Sent: Tuesday, August 13, 2019 2:16 PM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>;
> Alexandre Belloni <alexandre.belloni@bootlin.com>; Microchip Linux Driver
> Support <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap
>
> The 08/13/2019 02:12, Y.b. Lu wrote:
> > > -----Original Message-----
> > > From: Allan W. Nielsen <allan.nielsen@microchip.com>
> > > Sent: Monday, August 12, 2019 8:32 PM
> > > To: Y.b. Lu <yangbo.lu@nxp.com>
> > > Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>;
> > > Alexandre Belloni <alexandre.belloni@bootlin.com>; Microchip Linux
> > > Driver Support <UNGLinuxDriver@microchip.com>
> > > Subject: Re: [PATCH 3/3] ocelot_ace: fix action of trap
> > >
> > > The 08/12/2019 18:48, Yangbo Lu wrote:
> > > > The trap action should be copying the frame to CPU and dropping it
> > > > for forwarding, but current setting was just copying frame to CPU.
> > >
> > > Are there any actions which do a "copy-to-cpu" and still forward the
> > > frame in HW?
> >
> > [Y.b. Lu] We're using Felix switch whose code hadn't been accepted by
> upstream.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.ozlabs.org%2Fproject%2Fnetdev%2Flist%2F%3Fseries%3D115399%26s
> tat
> >
> e%3D*&data=02%7C01%7Cyangbo.lu%40nxp.com%7C42cd202cb17b45
> 69821708d
> >
> 71fb5c5de%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370127
> 37899910
> >
> 736&sdata=QnsDaWPHK9rb0XWg%2BduYEha6fuYSlv4YZdsu5f4kbfc%3D
> &res
> > erved=0
> >
> > I'd like to trap all IEEE 1588 PTP Ethernet frames to CPU through etype
> 0x88f7.
> > When I used current TRAP option, I found the frames were not only copied to
> CPU, but also forwarded to other ports.
> > So I just made the TRAP option same with DROP option except enabling
> CPU_COPY_ENA in the patch.
> This is still wrong to do - and it will not work for Ocelot (and I doubt it will
> work for your Felix target).
>
> The policer setting in the drop action ensure that the frame is dropped even if
> other pipe-line steps in the switch has set the copy-to-cpu flag.
>
> I think you can fix this patch my just clearing the port mask, and not set the
> policer.
[Y.b. Lu] Sorry. I missed your previous comments on the TRAP action.
With my configuration in the patch, it indeed worked. Maybe it was because "the CPU port is not touched by MASK_MODE" which I saw in RM.
I will try your suggestion too. It sound more proper.
Thanks.
>
> /Allan
next prev parent reply other threads:[~2019-08-14 4:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 10:48 [PATCH 0/3] ocelot_ace: fix and improve the driver Yangbo Lu
2019-08-12 10:48 ` [PATCH 1/3] ocelot_ace: drop member port from ocelot_ace_rule structure Yangbo Lu
2019-08-12 10:48 ` [PATCH 2/3] ocelot_ace: fix ingress ports setting for rule Yangbo Lu
2019-08-12 12:38 ` Allan W. Nielsen
2019-08-13 2:36 ` Y.b. Lu
2019-08-12 10:48 ` [PATCH 3/3] ocelot_ace: fix action of trap Yangbo Lu
2019-08-12 12:31 ` Allan W. Nielsen
2019-08-13 2:12 ` Y.b. Lu
2019-08-13 6:16 ` Allan W. Nielsen
2019-08-14 4:03 ` Y.b. Lu [this message]
2019-08-14 6:45 ` Allan W. Nielsen
2019-08-13 13:42 ` Andrew Lunn
2019-08-14 4:28 ` Y.b. Lu
2019-08-14 8:57 ` Allan W. Nielsen
2019-08-14 13:52 ` Andrew Lunn
2019-08-15 12:39 ` Y.b. Lu
2019-08-14 13:42 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB223711A1DB199D1C3CCFD9CCF8AD0@VI1PR0401MB2237.eurprd04.prod.outlook.com \
--to=yangbo.lu@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).