From: Andy Duan <fugang.duan@nxp.com>
To: Martin Fuzzey <martin.fuzzey@flowbird.group>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: RE: [EXT] [PATCH v2 2/4] ARM: dts: imx6: Use gpc for FEC interrupt controller to fix wake on LAN.
Date: Thu, 26 Mar 2020 07:45:59 +0000 [thread overview]
Message-ID: <VI1PR0402MB3600534A60ACE5E658196053FFCF0@VI1PR0402MB3600.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1585159919-11491-3-git-send-email-martin.fuzzey@flowbird.group>
From: Martin Fuzzey <martin.fuzzey@flowbird.group> Sent: Thursday, March 26, 2020 2:12 AM
> In order to wake from suspend by ethernet magic packets the GPC must be
> used as intc does not have wakeup functionality.
>
> But the FEC DT node currently uses interrupt-extended, specificying intc, thus
> breaking WoL.
>
> This problem is probably fallout from the stacked domain conversion as intc
> used to chain to GPC.
>
> So replace "interrupts-extended" by "interrupts" to use the default parent
> which is GPC.
>
> Fixes: b923ff6af0d5 ("ARM: imx6: convert GPC to stacked domains")
>
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index e6b4b85..bc488df 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -1039,9 +1039,8 @@
> compatible = "fsl,imx6q-fec";
> reg = <0x02188000 0x4000>;
> interrupt-names = "int0", "pps";
> - interrupts-extended =
> - <&intc 0 118
> IRQ_TYPE_LEVEL_HIGH>,
> - <&intc 0 119
> IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <0 118
> IRQ_TYPE_LEVEL_HIGH>,
> + <0 119
> + IRQ_TYPE_LEVEL_HIGH>;
Please remove the property "/delete-property/interrupts-extended;" in below file:
arch/arm/boot/dts/imx6qp.dtsi
> clocks = <&clks
> IMX6QDL_CLK_ENET>,
> <&clks
> IMX6QDL_CLK_ENET>,
> <&clks
> IMX6QDL_CLK_ENET_REF>;
> --
> 1.9.1
next prev parent reply other threads:[~2020-03-26 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:11 [PATCH v2 0/4] Fix Wake on lan with FEC on i.MX6 Martin Fuzzey
2020-03-25 18:11 ` [PATCH v2 1/4] net: fec: set GPR bit on suspend by DT configuration Martin Fuzzey
2020-03-26 7:57 ` [EXT] " Andy Duan
2020-03-25 18:11 ` [PATCH v2 2/4] ARM: dts: imx6: Use gpc for FEC interrupt controller to fix wake on LAN Martin Fuzzey
2020-03-26 7:45 ` Andy Duan [this message]
2020-03-25 18:11 ` [PATCH v2 3/4] dt-bindings: fec: document the new gpr property Martin Fuzzey
2020-03-26 7:58 ` [EXT] " Andy Duan
2020-03-31 21:55 ` Rob Herring
2020-03-25 18:11 ` [PATCH v2 4/4] ARM: dts: imx6: add fec " Martin Fuzzey
2020-03-26 7:59 ` [EXT] " Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB3600534A60ACE5E658196053FFCF0@VI1PR0402MB3600.eurprd04.prod.outlook.com \
--to=fugang.duan@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.fuzzey@flowbird.group \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).