netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* patch inclusion in lts trees
@ 2019-08-19 11:29 Madalin-cristian Bucur
  0 siblings, 0 replies; only message in thread
From: Madalin-cristian Bucur @ 2019-08-19 11:29 UTC (permalink / raw)
  To: fw, steffen.klassert; +Cc: netdev

Hi Florian, Steffen,

the fix below, addressing a problem from kernel v4.9, did not get picked
up in the lts trees, is there a reason for this? Are there more such fixes
that were left out?

Thank you,
Madalin

commit 7a474c36586f4277f930ab7e6865c97e44dfc3bc
Author: Florian Westphal <fw@strlen.de>
Date: Fri Jan 4 14:17:01 2019 +0100

xfrm: policy: increment xfrm_hash_generation on hash rebuild

Hash rebuild will re-set all the inexact entries, then re-insert them.
Lookups that can occur in parallel will therefore not find any policies.

This was safe when lookups were still guarded by rwlock.
After rcu-ification, lookups check the hash_generation seqcount to detect
when a hash resize takes place. Hash rebuild missed the needed increment.

Hash resizes and hash rebuilds cannot occur in parallel (both acquire
hash_resize_mutex), so just increment xfrm_hash_generation, like resize.

Fixes: a7c44247f704e3 ("xfrm: policy: make xfrm_policy_lookup_bytype lockless")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-08-19 11:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 11:29 patch inclusion in lts trees Madalin-cristian Bucur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).