From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A32C43381 for ; Mon, 4 Mar 2019 04:59:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB71E2082F for ; Mon, 4 Mar 2019 04:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="vyMH1FH9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726150AbfCDE7K (ORCPT ); Sun, 3 Mar 2019 23:59:10 -0500 Received: from mail-eopbgr150084.outbound.protection.outlook.com ([40.107.15.84]:44537 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725981AbfCDE7K (ORCPT ); Sun, 3 Mar 2019 23:59:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dsd91+O5bbbnidoYCex0eJxJT/WjhrtmqIZUa6ubtJE=; b=vyMH1FH9dIuE+yNxO9ZDRsE6i6ogy0MMNgrZgVYxG6laA5eHnO7C/K6CitsK6eemNLZ5f7vgM9aVwHHeg8VDu7hBkFttR/b0CnO/GIyCunnz+BZakkhBh0PirWRRzYZBPzyHBQ+XLFQVaK0HTdMQnaAMLvjny+Jd1x/oabuhSOU= Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com (10.169.135.8) by VI1PR0501MB2560.eurprd05.prod.outlook.com (10.168.137.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.18; Mon, 4 Mar 2019 04:59:04 +0000 Received: from VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59]) by VI1PR0501MB2271.eurprd05.prod.outlook.com ([fe80::a0b8:7ed8:d657:2f59%6]) with mapi id 15.20.1665.019; Mon, 4 Mar 2019 04:59:04 +0000 From: Parav Pandit To: Jiri Pirko , Jakub Kicinski CC: "davem@davemloft.net" , "oss-drivers@netronome.com" , "netdev@vger.kernel.org" Subject: RE: [PATCH net-next 2/8] devlink: add PF and VF port flavours Thread-Topic: [PATCH net-next 2/8] devlink: add PF and VF port flavours Thread-Index: AQHUzgCdohJWBeu08kmY7pH0eRUawaXzkJkAgAde9oA= Date: Mon, 4 Mar 2019 04:59:04 +0000 Message-ID: References: <20190226182436.23811-1-jakub.kicinski@netronome.com> <20190226182436.23811-3-jakub.kicinski@netronome.com> <20190227121644.GA2240@nanopsycho> In-Reply-To: <20190227121644.GA2240@nanopsycho> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=parav@mellanox.com; x-originating-ip: [68.203.16.89] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b98dccf-e889-450e-3acc-08d6a05e1ff4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0501MB2560; x-ms-traffictypediagnostic: VI1PR0501MB2560: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1;VI1PR0501MB2560;23:I4sr6mA7SHocdr/Rilf4jSKXjxLX+8EKzlljVyL?= =?us-ascii?Q?tGU+cKL/PMlMGix/xVp1GPs0MVNLwgXQjRb/iM853OTakrSG740XuMpR03dJ?= =?us-ascii?Q?3mAT2xZO66HwWuiNgGaJtSoGFXGPJN/IeZXquIdgsRQTzeFaDw4/tJLfSNPP?= =?us-ascii?Q?sKz0VIlgpNwcMPaWvDdUy0PPShgolYMelHCPPnHEqUQc0sGCbXPNH23yt15G?= =?us-ascii?Q?r3BNTNJFjX+1emphaEF/eILhbb0c9Kw+6vBNFg6Rwr6cLgprux/1fmGn/AMy?= =?us-ascii?Q?AgXRaVy8Zf7DRdI0oIq8YL9KFDJpGZI6CNIrFfe+PpnZ3mcMNIDRqCVgyTXS?= =?us-ascii?Q?VFiN2SswHNDC2YMt1Ur9GzlAeE17OGEEy3zfz4MW4zwjrzWlqCx65X+HhE2h?= =?us-ascii?Q?98VfRhN0GuOP3qJKc1FHo/EO5vEm7eqgBQeoUe0RaJCxsVRV/OiFMXOa6KwF?= =?us-ascii?Q?czk3hygcUySnJN42hhaJNBXvhOgbC7Hy6hV3eJbgQRiL7XN7Y0V84dW2H3mC?= =?us-ascii?Q?fSXQhW6xdy8lB8yqIX83cMJzoYawQpv9Ovc1G5eGZEHS/WjxEzBJXB8qouWn?= =?us-ascii?Q?YIFJrw6CjwNN46GaRTVcB0Gc6jVxOwjO04q6IdMPHJVBT/Pt0v5RUZY9H2Vt?= =?us-ascii?Q?yWfPW8IKW3HJsvJK/up8AZ9RSl2WIghPS55QKTy/pPJTGb5JGQ8PVLoPX9xg?= =?us-ascii?Q?lfwd6ZHONgeSUQtIdIh+LMnQOk70RNe/WwQ0Lr5KoA1MfSkegV3tBG2aucjs?= =?us-ascii?Q?WWzoOjCw1+KGHGW1jE7lkSFyBQ8G30YTseGw7Fa52VLJO1u/mQhhMMaDlcvl?= =?us-ascii?Q?zpKvmCB9nzil9a7NIgC2swfybvmf+eGJlMsiwrz+/fyah2f3v5Xrh+va1Inr?= =?us-ascii?Q?xUrDn909HdXlvelOhWEk28CdKAQ1DgjkXYYat2/vDzcitMOykTYKFpZcqlDY?= =?us-ascii?Q?OrEqLophE0vDD3Vg2QqNyUBvH9MWE5C1xz++QsVgdtDq2O8nzAni8qxrGYk7?= =?us-ascii?Q?tCFnCgAm4JXlIQP0SceqZztv55OnUGWF01jyCTn6J2ZDD+Vs+797CKqtTxgi?= =?us-ascii?Q?H1KAnguxzqXkQ1Gk52AbpljHgMzSu6xto4uqsDuIielRLH8u6LpcT/kMqJ8k?= =?us-ascii?Q?jAmpi/GkuYeWqylfgsGBKQFxoTKwfF3Kp6b2Ltrxesh1epvhMZH1uI3uUQUc?= =?us-ascii?Q?2f3lT7fCib4QvZQ4ykzJMmNFKqiLpzow+qLIJH3N67MpTfYDcaJQzB5Qseqb?= =?us-ascii?Q?Xv+DF+OJE99xDidqs753NUWfCxTlztl84k5WjUmk3SW90w/LK50CTG7ZDNNB?= =?us-ascii?Q?HzA=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09669DB681 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(396003)(346002)(39850400004)(136003)(366004)(13464003)(189003)(199004)(8676002)(99286004)(486006)(81156014)(81166006)(86362001)(11346002)(446003)(229853002)(55016002)(66066001)(33656002)(186003)(110136005)(316002)(7736002)(68736007)(53546011)(6506007)(9686003)(476003)(45080400002)(26005)(76176011)(6436002)(7696005)(256004)(305945005)(102836004)(74316002)(8936002)(105586002)(54906003)(6246003)(2906002)(25786009)(106356001)(5660300002)(52536013)(97736004)(14454004)(4326008)(53936002)(71200400001)(71190400001)(6116002)(3846002)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2560;H:VI1PR0501MB2271.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: anenSUPur2cyif/g6wQBxq7052GkDWe41YSnW3jci/PdRgpMS5ukAPVw2L/hfLP5oSyz9zL6n8+AM1mfVLFWp1j+rrkjfrpdvMCgzd8DYVmGOyLQbEkZX67EmMezG9rKqhD329ZxaEv/fczAZ1ISHkFrHgldsNCpaJCkv+MrceAqg5mAiWeCijTbckqc8QM0iMnpTu1nDmVk3ajuUOR/ItLp0EwsnX0UL1Op7j0JAqepqmd0Q7EBpLJYvis3r0l8qW7WY5x+mvIj6ze1NNAdqW3i3s0G15Nu8brET4mMbwmEYqEjpVrFkPMTIagipDW9jVJQaU9ZRurBeyLOXDbs1tGbLR8TS2sas3KzRUSJwLYHPqAZkidcSDH5JqBVSFL64O1KBIyh47QuYSJLfa5zfMV98Vd1Do358zDZ0XPIqPc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b98dccf-e889-450e-3acc-08d6a05e1ff4 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2019 04:59:04.0911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2560 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: netdev-owner@vger.kernel.org On > Behalf Of Jiri Pirko > Sent: Wednesday, February 27, 2019 6:17 AM > To: Jakub Kicinski > Cc: davem@davemloft.net; oss-drivers@netronome.com; > netdev@vger.kernel.org > Subject: Re: [PATCH net-next 2/8] devlink: add PF and VF port flavours >=20 > Tue, Feb 26, 2019 at 07:24:30PM CET, jakub.kicinski@netronome.com wrote: > >Current port flavours cover simple switches and DSA. Add PF and VF > >flavours to cover "switchdev" SR-IOV NICs. > > > >Example devlink user space output: > > > >$ devlink port > >pci/0000:82:00.0/0: type eth netdev p4p1 flavour physical > >pci/0000:82:00.0/10000: type eth netdev eth0 flavour pcie_pf pf 0 > >pci/0000:82:00.0/10001: type eth netdev eth1 flavour pcie_vf pf 0 vf 0 > >pci/0000:82:00.0/10002: type eth netdev eth2 flavour pcie_vf pf 0 vf 1 > A given port is of its parent device. In current scenario, its PF or VF. Hence it should be device attribute and not a port attribute. So devlink dev show command have to show what device flavour is. Is it well known PCI VF or PF or something else. It will show subdev device attribute and its parent PCI (PF/VF) devlink dev= ice. So we should have device flovour as PCI_PF or PCI_VF or SUBDEV. Again VF number showcasing here is very restrictive model. Every PF/VF/Subdev represents its own 'port' and it is connected to eswitch= 'port'. Instead of showing VF here, it must be this 'port' or 'link' number that gi= ves right view. Which netdev represents which VF is already linked in the VF rep-netdev sys= fs property. So flavour should be something like 'hostport' and when port is registered = for the eswitch side it should be 'switchport'. With this there is very clear picture of which hostport is connected to whi= ch eswitch port. Just like how we see in the physical world.