From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF9FC433E7 for ; Thu, 15 Oct 2020 02:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37E4822258 for ; Thu, 15 Oct 2020 02:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dektech.com.au header.i=@dektech.com.au header.b="vAgVHHMK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730515AbgJOCZX (ORCPT ); Wed, 14 Oct 2020 22:25:23 -0400 Received: from mail-am6eur05on2134.outbound.protection.outlook.com ([40.107.22.134]:31713 "EHLO EUR05-AM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726575AbgJOCZX (ORCPT ); Wed, 14 Oct 2020 22:25:23 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DGsmw1zXD/9OdtIOjuDAYe6lpfNZ0J5pUEQjDRewt1yIDVe/A0ZOmj8HTkpf7oFT2LgZk94k98URDBrAWvQn6L1mibfH7bWhemCoRRjXPHi4F/1fg3eP4MMrEEDmMHa+Ph23evK9qQNnvDtjjH/FmnVtd2ZqUeclww+Mfu2ziyFlvS4iamVdfyi2WTocDloU6zD4D/mK579FPXc1uhn9yF38MaUiAseNyE1cH37CWhIcHMQNlk+YD78ZaOohqr9CeRLoimbCgEjPUKrUe8g/mAKUNvOMLqjQ6s3AoxhQ/hRf7Xg/0cXurBaUykr6CrlH0kyRAREAcQl5iIUmAHdWTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLsZyw0VpwKrCYvlui12xpj2NjHJrNKGugLQMM8sgro=; b=d94nMylAQZmwbdfOi5e0Cf5RNyC2FBPn2LBrRETZGL6CLUuf5ov5S33F0JqZoZgJh9W55NejUR2W2JT0b3kXhvr8aPCkWdXEFIKU45chAdGKx3fQdgpUkOy4OsOza7G5JYz0LgaQ9PwjQ4fKdIYPewefNqt6DC01NMzrtPWlxfXGocfiAj/ojplx24k56K6rPAnZEr6bdSgRPvuFXxt5t/io3t6e/+LwZQyJBQ8bZj04zLEmfeCJTOcoL46ZGatkD1H/uHbFgIu8z8brjBb6qcjtFFCSFvW+18gaRNJ4FVSd8juedCgS46RBm5iIa/I8lNAYr+qHfVhCjXKHD2gErw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dektech.com.au; dmarc=pass action=none header.from=dektech.com.au; dkim=pass header.d=dektech.com.au; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dektech.com.au; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLsZyw0VpwKrCYvlui12xpj2NjHJrNKGugLQMM8sgro=; b=vAgVHHMKrKH0yL5xW/kBmWIQaHaAwEr3POUxZWfZEZjzmSvMBCpL2ytcA7YEVizYep22s/BxEG11NsgNu3Ksrx0+GMSUjCef4qxl4mTUsPjYB+I1OeH3wUOJgIJkspMA4QwmAQr9OM3yxunxJ/14Re4db3jFSK0nANiz3eYnin4= Received: from VI1PR05MB4605.eurprd05.prod.outlook.com (2603:10a6:802:61::21) by VI1PR0502MB2944.eurprd05.prod.outlook.com (2603:10a6:800:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Thu, 15 Oct 2020 02:25:11 +0000 Received: from VI1PR05MB4605.eurprd05.prod.outlook.com ([fe80::2459:8421:b4ec:dcb4]) by VI1PR05MB4605.eurprd05.prod.outlook.com ([fe80::2459:8421:b4ec:dcb4%6]) with mapi id 15.20.3455.031; Thu, 15 Oct 2020 02:25:11 +0000 From: Hoang Huu Le To: Jakub Kicinski CC: "tipc-discussion@lists.sourceforge.net" , "jmaloy@redhat.com" , "maloy@donjonn.com" , "ying.xue@windriver.com" , "netdev@vger.kernel.org" Subject: RE: [net] tipc: re-configure queue limit for broadcast link Thread-Topic: [net] tipc: re-configure queue limit for broadcast link Thread-Index: AQHWoSinCT30tNRl3EK1GSMaKHGEkamX1yMAgAAZ3uA= Date: Thu, 15 Oct 2020 02:25:11 +0000 Message-ID: References: <20201013061810.77866-1-hoang.h.le@dektech.com.au> <20201014174716.44b4fca3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201014174716.44b4fca3@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=dektech.com.au; x-originating-ip: [113.20.114.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23cee97f-b647-4aa4-fa88-08d870b18ad4 x-ms-traffictypediagnostic: VI1PR0502MB2944: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:486; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JzOvCrL0YH9TSXuzEmJcBeu4Bi0dNeywIGhnF4RDp70Fn/oPu4+lNRtnUfk3ppvMHz4jw6TWGAujZvvYCBxXT7kAM2smb2mIyhkjI+l6Jmtbx0xZWkwz0VZy0XmezhqjvkA8pOG5jV4lBETBzTh36UJFkabQbGN+LnNnxREv88MZFhrW91ZIyBhcG6VOSAgbADATLmESQAtMw0X0rr7TlbO7YqlI0b+BBLJuoM51Uaxs8U8uQbVj+1Pajcvc1/cl/VUt4C2TbSvgXcqKtVSrq5T4Cc+f0nE3EUx8qNgg1IG/hB5YqivdH8TuYT+PJmKla0p9RFxhHgfZaTy7T2mBkw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB4605.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(396003)(39840400004)(346002)(366004)(54906003)(33656002)(66946007)(7696005)(55016002)(186003)(2906002)(5660300002)(83380400001)(9686003)(316002)(8936002)(4326008)(71200400001)(52536014)(478600001)(66446008)(66476007)(8676002)(64756008)(66556008)(53546011)(86362001)(26005)(6916009)(6506007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: wtc0dVn9HlLXb3x+RfdTksVrh1vWJMBmHgXK3eNG1K+khzSojRFoY7AKjDQlRByZqJjj3LmGPd7yCosiSFXidZ74jvbhRgdfwPMlhWOkDIZf6zMIvqyP435cby4n2qVczzA6iYhoi0R9GFe3mtNZkSHtsZLWZ41Z6h8EufHA6dLMrtdiFvoFY6kM5tmOyt2poI+HTysHDSzf5cFtcifvYHNMXHh+ajfkBk618QNfD+SR79hf/qnIbhcYbli0FF6CHd0lhBcUd2ivPd0v6mkGa/xyBHYNA+U0t6/2UkMZCa3rrDoPtiKUhquQBrxmqQd7egegqQoNjWNDKSJSvf0eBt0VrgvOPabVWYAvmxkCtt3eryZMsAzYTh/9uK9lmsrxxjRZs4SgGH7icEpSo8Wkn/sgGocouUkK6J+r18vIZacEdgzPSqPRASbkLlDw5YwbygbUoVjowmIC72XbTv7NUUNqlJ3YrpSgEepTh68ovRRyTEjYj/IJGB2xQD952Y1bftZhzmbFD96Bzp4zYzYkrBA/2pSmHTtYIeI6nPzW22Yq3tbXT4qbJlQ/LiS8zI70ldqAYCENjrSwwWnttoS+YDlPC0ArXPtrovMHc7tWuWUPF5k+wDyMHU15fAt8pdCz0LxdnuQb3YP4mIxoE/7R8A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: dektech.com.au X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB4605.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23cee97f-b647-4aa4-fa88-08d870b18ad4 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2020 02:25:11.2021 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 1957ea50-0dd8-4360-8db0-c9530df996b2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7CD8t5MBjP1cM2s3CMxnvAZlvzxLETos1UgsaHSb1UBc80oE+U+nVuxdFmB2FWRfJcywW/JGUFuHe656Z2tFLfwO/+il2xrRmKdCE2Uh90k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB2944 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thanks for your reviewing. Yes, in this commit, we intend to fix the queue calculation limited, and,=20 besides we're planning to fix both in another fix. However, it should be us= ed the default (i.e BCLINK_WIN_DEFAULT) one. Since, we keep to choose fix window size for broadcast link. Regards, Hoang > -----Original Message----- > From: Jakub Kicinski > Sent: Thursday, October 15, 2020 7:47 AM > To: Hoang Huu Le > Cc: tipc-discussion@lists.sourceforge.net; jmaloy@redhat.com; maloy@donjo= nn.com; ying.xue@windriver.com; > netdev@vger.kernel.org > Subject: Re: [net] tipc: re-configure queue limit for broadcast link >=20 > On Tue, 13 Oct 2020 13:18:10 +0700 Hoang Huu Le wrote: > > The queue limit of the broadcast link is being calculated base on initi= al > > MTU. However, when MTU value changed (e.g manual changing MTU on NIC > > device, MTU negotiation etc.,) we do not re-calculate queue limit. > > This gives throughput does not reflect with the change. > > > > So fix it by calling the function to re-calculate queue limit of the > > broadcast link. > > > > Acked-by: Jon Maloy > > Signed-off-by: Hoang Huu Le > > --- > > net/tipc/bcast.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c > > index 940d176e0e87..c77fd13e2777 100644 > > --- a/net/tipc/bcast.c > > +++ b/net/tipc/bcast.c > > @@ -108,6 +108,7 @@ static void tipc_bcbase_select_primary(struct net *= net) > > { > > struct tipc_bc_base *bb =3D tipc_bc_base(net); > > int all_dests =3D tipc_link_bc_peers(bb->link); > > + int max_win =3D tipc_link_max_win(bb->link); > > int i, mtu, prim; > > > > bb->primary_bearer =3D INVALID_BEARER_ID; > > @@ -121,8 +122,11 @@ static void tipc_bcbase_select_primary(struct net = *net) > > continue; > > > > mtu =3D tipc_bearer_mtu(net, i); > > - if (mtu < tipc_link_mtu(bb->link)) > > + if (mtu < tipc_link_mtu(bb->link)) { > > tipc_link_set_mtu(bb->link, mtu); > > + tipc_link_set_queue_limits(bb->link, max_win, > > + max_win); >=20 > Is max/max okay here? Other places seem to use BCLINK_WIN_MIN. >=20 > > + } > > bb->bcast_support &=3D tipc_bearer_bcast_support(net, i); > > if (bb->dests[i] < all_dests) > > continue;