From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D1CC43333 for ; Thu, 14 Jan 2021 01:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42AF5235F9 for ; Thu, 14 Jan 2021 01:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728548AbhANBtP (ORCPT ); Wed, 13 Jan 2021 20:49:15 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:39322 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727019AbhANBtO (ORCPT ); Wed, 13 Jan 2021 20:49:14 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kzrkS-000Rcf-KU; Thu, 14 Jan 2021 02:48:28 +0100 Date: Thu, 14 Jan 2021 02:48:28 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: George McCollister , Vivien Didelot , Florian Fainelli , Rob Herring , "David S . Miller" , netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v4 1/3] dsa: add support for Arrow XRS700x tag trailer Message-ID: References: <20210113145922.92848-1-george.mccollister@gmail.com> <20210113145922.92848-2-george.mccollister@gmail.com> <20210114010519.td6q2pzy4mg6viuh@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210114010519.td6q2pzy4mg6viuh@skbuf> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 14, 2021 at 03:05:19AM +0200, Vladimir Oltean wrote: > On Wed, Jan 13, 2021 at 08:59:20AM -0600, George McCollister wrote: > > Add support for Arrow SpeedChips XRS700x single byte tag trailer. This > > is modeled on tag_trailer.c which works in a similar way. > > > > Signed-off-by: George McCollister > > Reviewed-by: Andrew Lunn > > Reviewed-by: Florian Fainelli > > --- > > Reviewed-by: Vladimir Oltean > > A few comments below. > > > diff --git a/net/dsa/tag_xrs700x.c b/net/dsa/tag_xrs700x.c > > new file mode 100644 > > index 000000000000..4ee7c260a8a9 > > --- /dev/null > > +++ b/net/dsa/tag_xrs700x.c > > @@ -0,0 +1,67 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * XRS700x tag format handling > > + * Copyright (c) 2008-2009 Marvell Semiconductor > > Why does Marvell get copyright? Probably because it started life as tag_trailer.c? Andrew