From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F05C433E0 for ; Wed, 13 Jan 2021 16:00:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB27D23434 for ; Wed, 13 Jan 2021 16:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727072AbhAMP7o (ORCPT ); Wed, 13 Jan 2021 10:59:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:38646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbhAMP7o (ORCPT ); Wed, 13 Jan 2021 10:59:44 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 083D02339F; Wed, 13 Jan 2021 15:59:02 +0000 (UTC) Date: Wed, 13 Jan 2021 17:00:09 +0100 From: Greg KH To: Geert Uytterhoeven Cc: "David S . Miller" , Jakub Kicinski , Hayes Wang , Marek Szyprowski , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y Message-ID: References: <20210113144309.1384615-1-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113144309.1384615-1-geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote: > In general, device drivers should not be enabled by default. > > Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver") > Signed-off-by: Geert Uytterhoeven > --- > drivers/net/usb/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig > index 1e37190287808973..fbbe786436319013 100644 > --- a/drivers/net/usb/Kconfig > +++ b/drivers/net/usb/Kconfig > @@ -631,7 +631,6 @@ config USB_NET_AQC111 > config USB_RTL8153_ECM > tristate "RTL8153 ECM support" > depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n) > - default y > help > This option supports ECM mode for RTL8153 ethernet adapter, when > CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not Reviewed-by: Greg Kroah-Hartman