From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB401C433DB for ; Sat, 9 Jan 2021 15:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D9A6238A1 for ; Sat, 9 Jan 2021 15:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726432AbhAIPzP (ORCPT ); Sat, 9 Jan 2021 10:55:15 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:58824 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbhAIPzP (ORCPT ); Sat, 9 Jan 2021 10:55:15 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kyGZK-00H7jv-Vb; Sat, 09 Jan 2021 16:54:22 +0100 Date: Sat, 9 Jan 2021 16:54:22 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , "David S. Miller" , Jakub Kicinski , Thomas Schreiber , Heiner Kallweit , Marek =?iso-8859-1?Q?Beh=FAn?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Message-ID: References: <20201230154755.14746-1-pali@kernel.org> <20210106153749.6748-1-pali@kernel.org> <20210106153749.6748-3-pali@kernel.org> <20210109154601.GZ1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210109154601.GZ1551@shell.armlinux.org.uk> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jan 09, 2021 at 03:46:01PM +0000, Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote: > > > From: Russell King > > > > > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both > > > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM. > > > > > > Such combination of bits is meaningless so assume that LOS signal is not > > > implemented. > > > > > > This patch fixes link carrier for GPON SFP module Ubiquiti U-Fiber Instant. > > > > > > Signed-off-by: Russell King > > > Signed-off-by: Pali Rohár > > > > Reviewed-by: Andrew Lunn > > I'd like to send this patch irrespective of discussion on the other > patches - I already have it committed in my repository with a different > description, but the patch content is the same. > > Are you happy if I transfer Andrew's r-b tag Hi Russell If it is the same contest, no problem. I can always NACK it later... Andrew