From: Andrey Ignatov <rdna@fb.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
Cong Wang <cong.wang@bytedance.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Dongdong Wang <wangdongdong.6@bytedance.com>
Subject: Re: [Patch bpf-next v2 5/5] selftests/bpf: add timeout map check in map_ptr tests
Date: Mon, 14 Dec 2020 12:41:31 -0800 [thread overview]
Message-ID: <X9fN+wQkSpYGuCfl@rdna-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201214201118.148126-6-xiyou.wangcong@gmail.com>
Cong Wang <xiyou.wangcong@gmail.com> [Mon, 2020-12-14 12:11 -0800]:
> From: Cong Wang <cong.wang@bytedance.com>
>
> Similar to regular hashmap test.
>
> Cc: Andrey Ignatov <rdna@fb.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Dongdong Wang <wangdongdong.6@bytedance.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Thanks.
Acked-by: Andrey Ignatov <rdna@fb.com>
> ---
> .../selftests/bpf/progs/map_ptr_kern.c | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/progs/map_ptr_kern.c b/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> index 34f9880a1903..f158b4f7e6c8 100644
> --- a/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> +++ b/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> @@ -648,6 +648,25 @@ static inline int check_ringbuf(void)
> return 1;
> }
>
> +struct {
> + __uint(type, BPF_MAP_TYPE_TIMEOUT_HASH);
> + __uint(max_entries, MAX_ENTRIES);
> + __type(key, __u32);
> + __type(value, __u32);
> +} m_timeout SEC(".maps");
> +
> +static inline int check_timeout_hash(void)
> +{
> + struct bpf_htab *timeout_hash = (struct bpf_htab *)&m_timeout;
> + struct bpf_map *map = (struct bpf_map *)&m_timeout;
> +
> + VERIFY(check_default(&timeout_hash->map, map));
> + VERIFY(timeout_hash->n_buckets == MAX_ENTRIES);
> + VERIFY(timeout_hash->elem_size == 72);
> +
> + return 1;
> +}
> +
> SEC("cgroup_skb/egress")
> int cg_skb(void *ctx)
> {
> @@ -679,6 +698,7 @@ int cg_skb(void *ctx)
> VERIFY_TYPE(BPF_MAP_TYPE_SK_STORAGE, check_sk_storage);
> VERIFY_TYPE(BPF_MAP_TYPE_DEVMAP_HASH, check_devmap_hash);
> VERIFY_TYPE(BPF_MAP_TYPE_RINGBUF, check_ringbuf);
> + VERIFY_TYPE(BPF_MAP_TYPE_TIMEOUT_HASH, check_timeout_hash);
>
> return 1;
> }
> --
> 2.25.1
>
--
Andrey Ignatov
next prev parent reply other threads:[~2020-12-14 20:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 20:11 [Patch bpf-next v2 0/5] bpf: introduce timeout map Cong Wang
2020-12-14 20:11 ` [Patch bpf-next v2 1/5] bpf: use index instead of hash for map_locked[] Cong Wang
2020-12-14 20:11 ` [Patch bpf-next v2 2/5] bpf: introduce timeout map Cong Wang
2020-12-15 19:27 ` Andrii Nakryiko
2020-12-15 20:06 ` Cong Wang
2020-12-15 22:03 ` Andrii Nakryiko
2020-12-15 23:23 ` Daniel Borkmann
2020-12-16 0:22 ` Cong Wang
2020-12-16 1:14 ` Alexei Starovoitov
2020-12-16 2:10 ` Cong Wang
2020-12-16 2:35 ` Alexei Starovoitov
2020-12-16 10:38 ` David Laight
2020-12-17 5:06 ` Cong Wang
2020-12-17 22:39 ` Daniel Borkmann
2020-12-16 0:15 ` Cong Wang
2020-12-16 18:35 ` Andrii Nakryiko
2020-12-17 6:29 ` Cong Wang
2020-12-17 21:14 ` Cong Wang
2020-12-18 19:14 ` Andrii Nakryiko
2020-12-18 19:13 ` Andrii Nakryiko
2020-12-14 20:11 ` [Patch bpf-next v2 3/5] selftests/bpf: update elem_size check in map ptr test Cong Wang
2020-12-14 20:40 ` Andrey Ignatov
2020-12-14 20:11 ` [Patch bpf-next v2 4/5] selftests/bpf: add a test case for bpf timeout map Cong Wang
2020-12-14 20:11 ` [Patch bpf-next v2 5/5] selftests/bpf: add timeout map check in map_ptr tests Cong Wang
2020-12-14 20:41 ` Andrey Ignatov [this message]
2020-12-15 19:28 ` [Patch bpf-next v2 0/5] bpf: introduce timeout map Andrii Nakryiko
2020-12-15 20:12 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9fN+wQkSpYGuCfl@rdna-mbp.dhcp.thefacebook.com \
--to=rdna@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=wangdongdong.6@bytedance.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).