From: Martin Habets <habetsm.xilinx@gmail.com>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Simon Horman <simon.horman@corigine.com>,
edward.cree@amd.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com, leon@kernel.org
Subject: Re: [RFC PATCH v2 net-next] sfc: support offloading TC VLAN push/pop actions to the MAE
Date: Tue, 28 Feb 2023 09:01:40 +0000 [thread overview]
Message-ID: <Y/3C9Lsjx03qxRXo@gmail.com> (raw)
In-Reply-To: <a35e32a0-0520-ce60-5296-39f36b278b5a@gmail.com>
On Mon, Feb 27, 2023 at 09:33:49PM +0000, Edward Cree wrote:
> On 24/02/2023 10:07, Simon Horman wrote:
> > On Thu, Feb 23, 2023 at 11:50:26PM +0000, edward.cree@amd.com wrote:
> >> + NL_SET_ERR_MSG_MOD(extack, "More than two VLAN pops, or action order violated");
> >
> > nit: I'm not sure if there is anything to be done about it,
> > but checkpatch complains about ling lines here...
>
> Yeah I don't think these can be helped. Breaking up the
> containing function (to reduce indent depth) would be
> rather synthetic imho, most of it wouldn't even be able
> to be shared with the decap and conntrack versions when
> those get added.)
You can put the string on it's own line, i.e. align it under
extack. I think that will pacify checkpatch.
Martin
>
> >> + }
> >> + tci = fa->vlan.vid & 0x0fff;
> >> + tci |= fa->vlan.prio << 13;
> >
> > nit: Maybe VLAN_PRIO_SHIFT and VLAN_VID_MASK can be used here.
>
> Yep good suggestion, incorporated for v3.
> Thanks for the review.
>
> -ed
prev parent reply other threads:[~2023-02-28 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 23:50 [RFC PATCH v2 net-next] sfc: support offloading TC VLAN push/pop actions to the MAE edward.cree
2023-02-24 10:07 ` Simon Horman
2023-02-27 21:33 ` Edward Cree
2023-02-28 9:01 ` Martin Habets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/3C9Lsjx03qxRXo@gmail.com \
--to=habetsm.xilinx@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=edward.cree@amd.com \
--cc=leon@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).