From: Hangbin Liu <liuhangbin@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] u32: fix TC_U32_TERMINAL printing
Date: Wed, 1 Mar 2023 11:10:26 +0800 [thread overview]
Message-ID: <Y/7CIiBcHabfFaD6@Laptop-X1> (raw)
In-Reply-To: <CAM0EoM=-sSuZbgjEH_KH8WTqTXYSagN0E6JLF+MKBFDSG_z9Hw@mail.gmail.com>
On Tue, Feb 28, 2023 at 05:55:30AM -0500, Jamal Hadi Salim wrote:
> Hangbin,
> Can you please run tdc tests on all tc (both for iproute2 and kernel)
> changes you make and preferably show them in the commit log? If you
> introduce something new then add a new tdc test case to cover it.
OK, the patch fixed an issue I found when run tdc u32 test.
1..11
not ok 1 afa9 - Add u32 with source match
Could not match regex pattern. Verify command output:
filter protocol ip pref 1 u32 chain 0
filter protocol ip pref 1 u32 chain 0 fh 800: ht divisor 1
filter protocol ip pref 1 u32 chain 0 fh 800::800 order 2048 key ht 800 bkt 0 *flowid 1:1 not_in_hw
match 7f000001/ffffffff at 12
action order 1: gact action pass
random type none pass val 0
index 1 ref 1 bind 1
After the fix, the u32.json test passed
All test results:
1..11
ok 1 afa9 - Add u32 with source match
ok 2 6aa7 - Add/Replace u32 with source match and invalid indev
ok 3 bc4d - Replace valid u32 with source match and invalid indev
ok 4 648b - Add u32 with custom hash table
ok 5 6658 - Add/Replace u32 with custom hash table and invalid handle
ok 6 9d0a - Replace valid u32 with custom hash table and invalid handle
ok 7 1644 - Add u32 filter that links to a custom hash table
ok 8 74c2 - Add/Replace u32 filter with invalid hash table id
ok 9 1fe6 - Replace valid u32 filter with invalid hash table id
ok 10 0692 - Test u32 sample option, divisor 256
ok 11 2478 - Test u32 sample option, divisor 16
When I post the patch, I though this issue is a clear logic one, so I didn't
paste the test result.
Thanks
Hangbin
next prev parent reply other threads:[~2023-03-01 3:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 3:49 [PATCH iproute2] u32: fix TC_U32_TERMINAL printing Hangbin Liu
2023-02-28 10:55 ` Jamal Hadi Salim
2023-03-01 3:10 ` Hangbin Liu [this message]
2023-03-01 3:24 ` Hangbin Liu
2023-03-01 11:55 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/7CIiBcHabfFaD6@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=dsahern@kernel.org \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).