From: Greg KH <gregkh@linuxfoundation.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jaewan Kim <jaewan@google.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-team@android.com, adelva@google.com
Subject: Re: [PATCH v7 1/4] mac80211_hwsim: add PMSR capability support
Date: Fri, 17 Feb 2023 10:41:20 +0100 [thread overview]
Message-ID: <Y+9LwLgA+Gm+3EHC@kroah.com> (raw)
In-Reply-To: <a117074810ef2c15ba3fa5fb60db2f5927e736eb.camel@sipsolutions.net>
On Fri, Feb 17, 2023 at 10:34:32AM +0100, Johannes Berg wrote:
> On Fri, 2023-02-17 at 10:31 +0100, Greg KH wrote:
> > On Fri, Feb 17, 2023 at 10:13:08AM +0100, Johannes Berg wrote:
> > > On Fri, 2023-02-17 at 08:43 +0100, Greg KH wrote:
> > > > On Fri, Feb 17, 2023 at 02:11:38PM +0900, Jaewan Kim wrote:
> > > > > BTW, can I expect you to review my changes for further patchsets?
> > > > > I sometimes get conflicting opinions (e.g. line limits)
> > > >
> > > > Sorry, I was the one that said "you can use 100 columns", if that's not
> > > > ok in the networking subsystem yet, that was my fault as it's been that
> > > > way in other parts of the kernel tree for a while.
> > > >
> > >
> > > Hah. Maybe that's my mistake then, I was still at "use 80 columns where
> > > it's simple, and more if it would look worse" ...
> >
> > It was changed back in 2020:
> > bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> >
> > seems to take a while to propagate out to all the subsystems :)
>
> Ah no, I was aware of that, but I guess we interpret this bit
> differently:
>
> +Statements longer than 80 columns should be broken into sensible chunks,
> +unless exceeding 80 columns significantly increases readability and does
> +not hide information.
>
>
> Here, I would've said something like:
>
> + if (request->request_lci && nla_put_flag(msg, NL80211_PMSR_FTM_REQ_ATTR_REQUEST_LCI))
> + return -ENOBUFS;
>
> can indeed "be broken into sensible chunks, unless ..."
>
> Just like this one already did:
>
> + if (request->request_civicloc &&
> + nla_put_flag(msg, NL80211_PMSR_FTM_REQ_ATTR_REQUEST_CIVICLOC))
> + return -ENOBUFS;
>
>
> Personally I think the latter is easier to read because scanning the
> long line for the logical break at "&&" is harder for me, but YMMV.
I think the latter is also better, so all is good :)
next prev parent reply other threads:[~2023-02-17 9:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 8:53 [PATCH v7 0/4] mac80211_hwsim: Add PMSR support Jaewan Kim
2023-02-07 8:53 ` [PATCH v7 1/4] mac80211_hwsim: add PMSR capability support Jaewan Kim
2023-02-07 9:08 ` Greg KH
2023-02-07 9:12 ` Greg KH
2023-02-15 18:01 ` Johannes Berg
2023-02-17 5:11 ` Jaewan Kim
2023-02-17 7:43 ` Greg KH
2023-02-17 9:13 ` Johannes Berg
2023-02-17 9:31 ` Greg KH
2023-02-17 9:34 ` Johannes Berg
2023-02-17 9:41 ` Greg KH [this message]
2023-02-17 9:19 ` Johannes Berg
2023-02-07 8:53 ` [PATCH v7 2/4] mac80211_hwsim: add PMSR request support via virtio Jaewan Kim
2023-02-15 18:07 ` Johannes Berg
2023-02-23 15:38 ` Jaewan Kim
2023-02-28 15:06 ` Johannes Berg
2023-02-07 8:53 ` [PATCH v7 3/4] mac80211_hwsim: add PMSR abort " Jaewan Kim
2023-02-07 8:54 ` [PATCH v7 4/4] mac80211_hwsim: add PMSR report " Jaewan Kim
2023-02-15 18:13 ` Johannes Berg
2023-02-07 9:06 ` [PATCH v7 0/4] mac80211_hwsim: Add PMSR support Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+9LwLgA+Gm+3EHC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adelva@google.com \
--cc=jaewan@google.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-team@android.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).