From: Leon Romanovsky <leon@kernel.org>
To: Peilin Ye <yepeilin.cs@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Peilin Ye <peilin.ye@bytedance.com>,
Cong Wang <cong.wang@bytedance.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4] net/sock: Introduce trace_sk_data_ready()
Date: Thu, 13 Oct 2022 12:43:29 +0300 [thread overview]
Message-ID: <Y0fdwSkyoFI2SDuw@unreal> (raw)
In-Reply-To: <20221012232121.27374-1-yepeilin.cs@gmail.com>
On Wed, Oct 12, 2022 at 04:21:21PM -0700, Peilin Ye wrote:
> From: Peilin Ye <peilin.ye@bytedance.com>
>
> As suggested by Cong, introduce a tracepoint for all ->sk_data_ready()
> callback implementations. For example:
>
> <...>
> ksoftirqd/0-16 [000] ..s.. 99.784482: sk_data_ready: family=10 protocol=58 func=sock_def_readable
> ksoftirqd/0-16 [000] ..s.. 99.784819: sk_data_ready: family=10 protocol=58 func=sock_def_readable
> <...>
>
> Suggested-by: Cong Wang <cong.wang@bytedance.com>
> Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
> ---
> changes since v3:
> - Avoid using __func__ everywhere (Leon Romanovsky)
> - No need to trace iscsi_target_sk_data_ready() (Leon Romanovsky)
I meant no need both trace point and debug print and suggested to remove
debug print.
Thanks
next prev parent reply other threads:[~2022-10-13 9:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 22:15 [PATCH net-next] net/sock: Introduce trace_sk_data_ready() Peilin Ye
2022-09-29 16:18 ` Jakub Kicinski
2022-10-05 0:06 ` Peilin Ye
2022-09-29 16:19 ` Eric Dumazet
2022-10-05 0:14 ` Peilin Ye
2022-10-07 22:10 ` [PATCH net-next v2] " Peilin Ye
2022-10-08 0:38 ` kernel test robot
2022-10-08 1:11 ` Peilin Ye
2022-10-08 0:48 ` kernel test robot
2022-10-11 19:58 ` [PATCH net-next v3] " Peilin Ye
2022-10-12 5:58 ` Leon Romanovsky
2022-10-12 17:57 ` Peilin Ye
2022-10-12 23:21 ` [PATCH net-next v4] " Peilin Ye
2022-10-13 9:43 ` Leon Romanovsky [this message]
2022-10-13 23:58 ` Peilin Ye
2022-10-14 0:00 ` [PATCH net-next v5] " Peilin Ye
2022-10-14 6:35 ` Leon Romanovsky
2022-11-10 2:28 ` Peilin Ye
2022-10-15 20:07 ` [PATCH net-next] " Cong Wang
2022-10-15 20:26 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0fdwSkyoFI2SDuw@unreal \
--to=leon@kernel.org \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peilin.ye@bytedance.com \
--cc=yepeilin.cs@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).