Re: [PATCH net-next 04/13] ice: split ice_vsi_setup into smaller functions

[Michal Swiatkowski <michal.swiatkowski@linux.intel.com>]

On Mon, Nov 14, 2022 at 09:08:25PM -0800, Jakub Kicinski wrote:
> On Mon, 14 Nov 2022 13:57:46 +0100 Michal Swiatkowski wrote:
> > Main goal is to reuse the same functions in VSI config and rebuild
> > paths.
> > To do this split ice_vsi_setup into smaller pieces and reuse it during
> > rebuild.
> > 
> > ice_vsi_alloc() should only alloc memory, not set the default values
> > for VSI.
> > Move setting defaults to separate function. This will allow config of
> > already allocated VSI, for example in reload path.
> > 
> > The path is mostly moving code around without introducing new
> > functionality. Functions ice_vsi_cfg() and ice_vsi_decfg() were
> > added, but they are using code that already exist.
> > 
> > Use flag to pass information about VSI initialization during rebuild
> > instead of using boolean value.
> > 
> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> > Co-developed-by: Jacob Keller <jacob.e.keller@intel.com>
> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> 
> nit:
> 
> drivers/net/ethernet/intel/ice/ice_lib.c:459: warning: Function parameter or member 'vsi' not described in 'ice_vsi_alloc_def'
> drivers/net/ethernet/intel/ice/ice_lib.c:459: warning: Excess function parameter 'vsi_type' description in 'ice_vsi_alloc_def'
> 
> Sorry, didn't get to actually reviewing because of the weekend backlog.
> Will do tomorrow.

Thanks, I will fix it in next version.