From: Andrew Lunn <andrew@lunn.ch>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next 2/4] tsnep: Fix rotten packets
Date: Thu, 17 Nov 2022 21:39:11 +0100 [thread overview]
Message-ID: <Y3ab7xim0EfyCQHm@lunn.ch> (raw)
In-Reply-To: <20221117201440.21183-3-gerhard@engleder-embedded.com>
On Thu, Nov 17, 2022 at 09:14:38PM +0100, Gerhard Engleder wrote:
> If PTP synchronisation is done every second, then sporadic the interval
> is higher than one second:
>
> ptp4l[696.582]: master offset -17 s2 freq -1891 path delay 573
> ptp4l[697.582]: master offset -22 s2 freq -1901 path delay 573
> ptp4l[699.368]: master offset -1 s2 freq -1887 path delay 573
> ^^^^^^^ Should be 698.582!
>
> This problem is caused by rotten packets, which are received after
> polling but before interrupts are enabled again.
Is this a hardware bug? At the end of the interrupt coalescence
period, should it not check the queue and fire an interrupt?
Andrew
next prev parent reply other threads:[~2022-11-17 20:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 20:14 [PATCH net-next 0/4] tsnep: Throttle irq, rotten pkts, RX buffer alloc and ethtool_get_channels() Gerhard Engleder
2022-11-17 20:14 ` [PATCH net-next 1/4] tsnep: Throttle interrupts Gerhard Engleder
2022-11-17 20:33 ` Andrew Lunn
2022-11-18 5:50 ` Gerhard Engleder
2022-11-19 1:24 ` Jakub Kicinski
2022-11-19 20:46 ` Gerhard Engleder
2022-11-17 20:14 ` [PATCH net-next 2/4] tsnep: Fix rotten packets Gerhard Engleder
2022-11-17 20:39 ` Andrew Lunn [this message]
2022-11-18 6:13 ` Gerhard Engleder
2022-11-19 1:26 ` Jakub Kicinski
2022-11-19 20:47 ` Gerhard Engleder
2022-11-17 20:14 ` [PATCH net-next 3/4] tsnep: Add ethtool get_channels support Gerhard Engleder
2022-11-17 20:14 ` [PATCH net-next 4/4] tsnep: Rework RX buffer allocation Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3ab7xim0EfyCQHm@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).