> On Mon, 21 Nov 2022 09:59:25 +0100 Lorenzo Bianconi wrote: > > +#define mtk_wed_device_tx_ring_setup(_dev, _ring, _regs, _reset) \ > > + (_dev)->ops->tx_ring_setup(_dev, _ring, _regs, _reset) > > FWIW I find the "op macros" quite painful when trying to read a driver > I'm not familiar with. stmmac does this, too. Just letting you know, > it is what it is. ack, fine. I maintained the approach currently used in the driver. Do you prefer to run the function pointer directly? Regards, Lorenzo