From: asmadeus@codewreck.org
To: Ye Bin <yebin@huaweicloud.com>
Cc: ericvh@gmail.com, lucho@ionkov.net, linux_oss@crudebyte.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, v9fs-developer@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yebin10@huawei.com
Subject: Re: [PATCH 0/5] Fix error handle in 'rdma_request()'
Date: Tue, 22 Nov 2022 09:27:02 +0900 [thread overview]
Message-ID: <Y3wXVkp4ne7JQGWQ@codewreck.org> (raw)
In-Reply-To: <20221121080049.3850133-1-yebin@huaweicloud.com>
Ye Bin wrote on Mon, Nov 21, 2022 at 04:00:44PM +0800:
> Ye Bin (5):
Thanks for these patches.
The commit messages are a bit difficult, but code changes mostly look
good to me -- I'll do a proper review when I can find time to test.
Just one question first: do you have RDMA hardware at huawei and/or
actually use this, or is it all static analysis fixes ?
(regardless of whether these problems actually happened with that
hardware, I'd like to know if this has had a first round of test or not)
--
Dominique
prev parent reply other threads:[~2022-11-22 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 8:00 [PATCH 0/5] Fix error handle in 'rdma_request()' Ye Bin
2022-11-21 8:00 ` [PATCH 1/5] 9p: fix miss unmap request " Ye Bin
2022-11-21 8:00 ` [PATCH 2/5] 9p: fix miss release semaphore " Ye Bin
2022-11-21 8:00 ` [PATCH 3/5] 9p: fix error handle in 'post_recv()' Ye Bin
2022-11-21 8:00 ` [PATCH 4/5] 9p: factor out 'post_send()' Ye Bin
2022-11-21 8:00 ` [PATCH 5/5] 9p: refactor 'post_recv()' Ye Bin
2022-11-22 0:27 ` asmadeus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3wXVkp4ne7JQGWQ@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=yebin10@huawei.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).