From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0FBC54EBC for ; Tue, 10 Jan 2023 10:29:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbjAJK3N (ORCPT ); Tue, 10 Jan 2023 05:29:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbjAJK3L (ORCPT ); Tue, 10 Jan 2023 05:29:11 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98A3A1A38A; Tue, 10 Jan 2023 02:29:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 36018615B0; Tue, 10 Jan 2023 10:29:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C952DC433D2; Tue, 10 Jan 2023 10:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673346549; bh=z+0BWX2kSw+tuaITOB1eHSwdHQC4uPPD5XkVxlkUGcE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xvnd7/kMMmFAF/mj2qfSx6VD9KB+Yhlg3k64CZMR2hYqDu1UH1Nb4ANRqWMH5812d mNSu1Mc79/TZBTntC8/ZO7CFph59XtJGwnRwpo9dczyXDjamwUJ0yrXKNY965aMJ9n kNa0ans+gcBA8rUEnP+TnrRcTuC1Rf+H8jsNMLgWmim/dU7Lm98eyVy+UHR5n+geNS Ek1DDcmlXBnO0qiO6Z9YgY++obdAE9pi5pjuUdXV4P0dlaWaf5yJPCTVGELkGrMR+x biVCqzZmH8P5VeodR51KY0W1fcPtco5A3gmmQ2VM9NcCHmUG6J8sFYF+29eGEjuA8T ziM38v7FPU/rA== Date: Tue, 10 Jan 2023 12:29:04 +0200 From: Leon Romanovsky To: pabeni@redhat.com Cc: Hariprasad Kelam , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com Subject: Re: [net PATCH] octeontx2-pf: Fix resource leakage in VF driver unbind Message-ID: References: <20230109061325.21395-1-hkelam@marvell.com> <167334601536.23804.3249818012090319433.git-patchwork-notify@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167334601536.23804.3249818012090319433.git-patchwork-notify@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 10, 2023 at 10:20:15AM +0000, patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This patch was applied to netdev/net.git (master) > by Paolo Abeni : > > On Mon, 9 Jan 2023 11:43:25 +0530 you wrote: > > resources allocated like mcam entries to support the Ntuple feature > > and hash tables for the tc feature are not getting freed in driver > > unbind. This patch fixes the issue. > > > > Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count") > > Signed-off-by: Hariprasad Kelam > > Signed-off-by: Sunil Kovvuri Goutham > > > > [...] > > Here is the summary with links: > - [net] octeontx2-pf: Fix resource leakage in VF driver unbind > https://git.kernel.org/netdev/net/c/53da7aec3298 Paolo, I don't think that this patch should be applied. It looks like wrong Fixes to me and I don't see clearly how structures were allocated on VF which were cleared in this patch. Thanks > > You are awesome, thank you! > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html > >