From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, michael.chan@broadcom.com,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
tariqt@nvidia.com, saeedm@nvidia.com, leon@kernel.org,
idosch@nvidia.com, petrm@nvidia.com, mailhol.vincent@wanadoo.fr,
jacob.e.keller@intel.com, gal@nvidia.com
Subject: Re: [patch net-next v3 01/11] devlink: remove devlink features
Date: Tue, 10 Jan 2023 08:12:10 +0100 [thread overview]
Message-ID: <Y70PyuHXJZ3gD8dG@nanopsycho> (raw)
In-Reply-To: <20230109165500.3bebda0a@kernel.org>
Tue, Jan 10, 2023 at 01:55:00AM CET, kuba@kernel.org wrote:
>On Mon, 9 Jan 2023 19:31:10 +0100 Jiri Pirko wrote:
>> Note that mlx5 used this to enable devlink reload conditionally only
>> when device didn't act as multi port slave. Move the multi port check
>> into mlx5_devlink_reload_down() callback alongside with the other
>> checks preventing the device from reload in certain states.
>
>Right, but this is not 100% equivalent because we generate the
>notifications _before_ we try to reload_down:
>
> devlink_ns_change_notify(devlink, dest_net, curr_net, false);
> err = devlink->ops->reload_down(devlink, !!dest_net, action, limit, extack);
> if (err)
> return err;
>
>IDK why, I haven't investigated.
Right, but that is done even in other cases where down can't be done. I
I think there's a bug here, down DEL notification is sent before calling
down which can potentially fail. I think the notification call should be
moved after reload_down() call. Then the bahaviour would stay the same
for the features case and will get fixed for the reload_down() reject
cases. What do you think?
next prev parent reply other threads:[~2023-01-10 7:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 18:31 [patch net-next v3 00/11] devlink: features, linecard and reporters locking cleanup Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 01/11] devlink: remove devlink features Jiri Pirko
2023-01-10 0:55 ` Jakub Kicinski
2023-01-10 7:12 ` Jiri Pirko [this message]
2023-01-10 20:59 ` Jakub Kicinski
2023-01-11 7:36 ` Leon Romanovsky
2023-01-11 8:23 ` Jiri Pirko
2023-01-11 12:04 ` Leon Romanovsky
2023-01-09 18:31 ` [patch net-next v3 02/11] devlink: remove linecards lock Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 03/11] devlink: remove linecard reference counting Jiri Pirko
2023-01-10 8:10 ` Ido Schimmel
2023-01-09 18:31 ` [patch net-next v3 04/11] devlink: protect health reporter operation with instance lock Jiri Pirko
2023-01-10 8:37 ` Ido Schimmel
2023-01-09 18:31 ` [patch net-next v3 05/11] devlink: remove reporters_lock Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 06/11] devlink: remove devl_port_health_reporter_destroy() Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 07/11] devlink: remove reporter reference counting Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 08/11] devlink: convert linecards dump to devlink_nl_instance_iter_dump() Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 09/11] devlink: convert reporters " Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 10/11] devlink: remove devlink_dump_for_each_instance_get() helper Jiri Pirko
2023-01-09 18:31 ` [patch net-next v3 11/11] devlink: add instance lock assertion in devl_is_registered() Jiri Pirko
2023-01-10 1:13 ` [patch net-next v3 00/11] devlink: features, linecard and reporters locking cleanup Jakub Kicinski
2023-01-10 8:40 ` Ido Schimmel
2023-01-11 7:14 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y70PyuHXJZ3gD8dG@nanopsycho \
--to=jiri@resnulli.us \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=tariqt@nvidia.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).