From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, lorenzo.bianconi@redhat.com,
nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, sujuan.chen@mediatek.com,
daniel@makrotopia.org, kvalo@kernel.org
Subject: Re: [PATCH v2 net-next 5/5] net: ethernet: mtk_wed: add reset/reset_complete callbacks
Date: Thu, 5 Jan 2023 12:49:49 +0100 [thread overview]
Message-ID: <Y7a5XeLjTj1MNCDz@lore-desk> (raw)
In-Reply-To: <Y7aW3k4xZVfDb6oh@unreal>
[-- Attachment #1: Type: text/plain, Size: 3165 bytes --]
> On Wed, Jan 04, 2023 at 03:59:17PM +0100, Lorenzo Bianconi wrote:
> > > On Wed, Jan 04, 2023 at 03:03:14PM +0100, Lorenzo Bianconi wrote:
> > > > Introduce reset and reset_complete wlan callback to schedule WLAN driver
> > > > reset when ethernet/wed driver is resetting.
> > > >
> > > > Tested-by: Daniel Golle <daniel@makrotopia.org>
> > > > Co-developed-by: Sujuan Chen <sujuan.chen@mediatek.com>
> > > > Signed-off-by: Sujuan Chen <sujuan.chen@mediatek.com>
> > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > > ---
> > > > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 6 ++++
> > > > drivers/net/ethernet/mediatek/mtk_wed.c | 40 +++++++++++++++++++++
> > > > drivers/net/ethernet/mediatek/mtk_wed.h | 8 +++++
> > > > include/linux/soc/mediatek/mtk_wed.h | 2 ++
> > > > 4 files changed, 56 insertions(+)
> > > >
> > > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> > > > index bafae4f0312e..2d74e26f45c9 100644
> > > > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> > > > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> > > > @@ -3913,6 +3913,10 @@ static void mtk_pending_work(struct work_struct *work)
> > > > mtk_w32(eth, val, MTK_MAC_MCR(i));
> > > > }
> > > >
> > > > + rtnl_unlock();
> > > > + mtk_wed_fe_reset();
> > > > + rtnl_lock();
> > >
> > > Is it safe to call rtnl_unlock(), perform some work and lock again?
> >
> > Yes, mtk_pending_work sets MTK_RESETTING bit and a new reset work is not
> > scheduled until this bit is cleared
>
> I'm more worried about opening a window for user-space access while you
> are performing FW reset.
ack, right. I will work on it.
>
> <...>
>
> > > > diff --git a/include/linux/soc/mediatek/mtk_wed.h b/include/linux/soc/mediatek/mtk_wed.h
> > > > index db637a13888d..ddff54fc9717 100644
> > > > --- a/include/linux/soc/mediatek/mtk_wed.h
> > > > +++ b/include/linux/soc/mediatek/mtk_wed.h
> > > > @@ -150,6 +150,8 @@ struct mtk_wed_device {
> > > > void (*release_rx_buf)(struct mtk_wed_device *wed);
> > > > void (*update_wo_rx_stats)(struct mtk_wed_device *wed,
> > > > struct mtk_wed_wo_rx_stats *stats);
> > > > + int (*reset)(struct mtk_wed_device *wed);
> > > > + int (*reset_complete)(struct mtk_wed_device *wed);
> > >
> > > I don't see any driver implementation of these callbacks in this series.
> > > Did I miss it?
> >
> > These callbacks are implemented in the mt76 driver. I have not added these
> > patches to the series since mt76 patches usually go through Felix/Kalle's
> > trees (anyway I am fine to add them to the series if they can go into net-next
> > directly).
>
> Usually patches that use specific functionality are submitted together
> with API changes.
I would say it is better mt76 patches go through Felix/Kalle's tree in order to avoid
conflicts.
@Felix, Kalle: any opinions?
Regards,
Lorenzo
>
> >
> > Regards,
> > Lorenzo
> >
> > >
> > > Thanks
> > >
> > > > } wlan;
> > > > #endif
> > > > };
> > > > --
> > > > 2.39.0
> > > >
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-05 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:03 [PATCH v2 net-next 0/5] net: ethernet: mtk_wed: introduce reset support Lorenzo Bianconi
2023-01-04 14:03 ` [PATCH v2 net-next 1/5] net: ethernet: mtk_eth_soc: introduce mtk_hw_reset utility routine Lorenzo Bianconi
2023-01-04 14:03 ` [PATCH v2 net-next 2/5] net: ethernet: mtk_eth_soc: introduce mtk_hw_warm_reset support Lorenzo Bianconi
2023-01-04 14:03 ` [PATCH v2 net-next 3/5] net: ethernet: mtk_eth_soc: align reset procedure to vendor sdk Lorenzo Bianconi
2023-01-04 14:03 ` [PATCH v2 net-next 4/5] net: ethernet: mtk_eth_soc: add dma checks to mtk_hw_reset_check Lorenzo Bianconi
2023-01-04 14:03 ` [PATCH v2 net-next 5/5] net: ethernet: mtk_wed: add reset/reset_complete callbacks Lorenzo Bianconi
2023-01-04 14:17 ` Leon Romanovsky
2023-01-04 14:59 ` Lorenzo Bianconi
2023-01-05 9:22 ` Leon Romanovsky
2023-01-05 11:49 ` Lorenzo Bianconi [this message]
2023-01-06 5:48 ` Jakub Kicinski
2023-01-06 9:11 ` Lorenzo Bianconi
2023-01-09 14:46 ` Kalle Valo
2023-01-07 14:39 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7a5XeLjTj1MNCDz@lore-desk \
--to=lorenzo@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=leon@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=sujuan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).