From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE62C63797 for ; Sun, 8 Jan 2023 17:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233502AbjAHRYw (ORCPT ); Sun, 8 Jan 2023 12:24:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjAHRYu (ORCPT ); Sun, 8 Jan 2023 12:24:50 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12A37BE14; Sun, 8 Jan 2023 09:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WNyoZTkoExUmXqvGesIlbw00ZoUJyc/GjFEcWcL7Kds=; b=qUzNX0tRX01ErBEc7fP7m/YKw5 Vl9A2wqkoOPgdtb/ViHgWzLFySziDrbsGPQEciuxYE+eLJ2KJVrCt0s1tsGMEzTjJ5oBN8T6HAt98 ZueqRxzfQxwffqrB7FC8wOEqeDDr4yI1l9Y+nDUAJDOKnoK38QQ+lNzRMH67/RDrrUV86MVwShjUh +od5SncJtBeR3pIMyQS29S8Pj1NK4eSP6VKZSHR1kC1jvx6WKK3F0UPToatlxbaxBYEibfbmLL6sj 6tNls6oW09X/F17GUl3TAwy3L5sEH2aauE39Vs8oEPzgJXSsd/t5C0rh+dxSXjRUdZAknWbzX/Vet FlfKKoww==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEZPZ-00EZ7r-S9; Sun, 08 Jan 2023 17:24:45 +0000 Date: Sun, 8 Jan 2023 09:24:45 -0800 From: Christoph Hellwig To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, Christoph Hellwig , David Hildenbrand , Michal Hocko , Peter Xu , Nadav Amit , Matthew Wilcox , Vlastimil Babka , Rik van Riel , Will Deacon , Michael Ellerman , Palmer Dabbelt , Christian Borntraeger , Dave Hansen , Christian Brauner , Eric Dumazet , Andrew Morton Subject: Re: [PATCH] mm: remove zap_page_range and create zap_vma_pages Message-ID: References: <20230104002732.232573-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104002732.232573-1-mike.kravetz@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I would have split this into one patch that adds the new zap_vma_pages helper, and one to remove zap_page_range to split the separate changes. But the overall result looks fine, so feel free to add: Reviewed-by: Christoph Hellwig to this or the split patches.