From: Andrei Gherzan <andrei.gherzan@canonical.com>
To: Willem de Bruijn <willemb@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] selftests: net: udpgso_bench_rx/tx: Stop when wrong CLI args are provided
Date: Tue, 31 Jan 2023 14:40:18 +0000 [thread overview]
Message-ID: <Y9koUno9kGkNJkma@qwirkle> (raw)
In-Reply-To: <CA+FuTSf1ffpep=wV=__J96Ju_nPkd96=c+ny4mC+SxrhRp0ofA@mail.gmail.com>
On 23/01/31 08:35AM, Willem de Bruijn wrote:
> On Tue, Jan 31, 2023 at 8:08 AM Andrei Gherzan
> <andrei.gherzan@canonical.com> wrote:
> >
> > Leaving unrecognized arguments buried in the output, can easily hide a
> > CLI/script typo. Avoid this by exiting when wrong arguments are provided to
> > the udpgso_bench test programs.
> >
> > Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com>
>
> I'm on the fence on this. Test binaries are not necessarily robust
> against bad input. If you insist.
I'll keep it in the set (for next v), but I don't mind if it doesn't end
up applied. It was just something I stumbled into.
> When sending patches to net, please always add a Fixes tag.
I'll keep that in mind.
--
Andrei Gherzan
next prev parent reply other threads:[~2023-01-31 14:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 13:04 [PATCH v2 1/4] selftests: net: udpgso_bench_rx: Fix 'used uninitialized' compiler warning Andrei Gherzan
2023-01-31 13:04 ` [PATCH v2 2/4] selftests: net: udpgso_bench_rx/tx: Stop when wrong CLI args are provided Andrei Gherzan
2023-01-31 13:35 ` Willem de Bruijn
2023-01-31 14:40 ` Andrei Gherzan [this message]
2023-01-31 13:04 ` [PATCH v2 3/4] selftests: net: udpgso_bench: Fix racing bug between the rx/tx programs Andrei Gherzan
2023-01-31 13:33 ` Willem de Bruijn
2023-01-31 14:45 ` Paolo Abeni
2023-01-31 14:56 ` Andrei Gherzan
2023-01-31 13:04 ` [PATCH v2 4/4] selftests: net: udpgso_bench_tx: Cater for pending datagrams zerocopy benchmarking Andrei Gherzan
2023-01-31 13:39 ` Willem de Bruijn
2023-01-31 14:51 ` Paolo Abeni
2023-01-31 15:08 ` Andrei Gherzan
2023-01-31 16:22 ` Paolo Abeni
2023-01-31 16:31 ` Andrei Gherzan
2023-01-31 18:26 ` Paolo Abeni
2023-01-31 20:36 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9koUno9kGkNJkma@qwirkle \
--to=andrei.gherzan@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).