From: Simon Horman <simon.horman@corigine.com>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com, Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH net-next v2 2/2] amd-xgbe: add support for rx-adaptation
Date: Wed, 1 Feb 2023 18:11:34 +0100 [thread overview]
Message-ID: <Y9qdRsS5txwu3MND@corigine.com> (raw)
In-Reply-To: <20230201054932.212700-3-Raju.Rangoju@amd.com>
On Wed, Feb 01, 2023 at 11:19:32AM +0530, Raju Rangoju wrote:
> The existing implementation for non-Autonegotiation 10G speed modes does
> not enable RX adaptation in the Driver and FW. The RX Equalization
> settings (AFE settings alone) are manually configured and the existing
> link-up sequence in the driver does not perform rx adaptation process as
> mentioned in the Synopsys databook. There's a customer request for 10G
> backplane mode without Auto-negotiation and for the DAC cables of more
> significant length that follow the non-Autonegotiation mode. These modes
> require PHY to perform RX Adaptation.
>
> The proposed logic adds the necessary changes to Yellow Carp devices to
> ensure seamless RX Adaptation for 10G-SFI (LONG DAC) and 10G-KR without
> AN (CL72 not present). The RX adaptation core algorithm is executed by
> firmware, however, to achieve that a new mailbox sub-command is required
> to be sent by the driver.
>
> Co-developed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
...
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h b/drivers/net/ethernet/amd/xgbe/xgbe.h
> index 16e73df3e9b9..ad136ed493ed 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe.h
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe.h
> @@ -625,6 +625,7 @@ enum xgbe_mb_cmd {
>
> enum xgbe_mb_subcmd {
> XGBE_MB_SUBCMD_NONE = 0,
> + XGBE_MB_SUBCMD_RX_ADAP,
>
> /* 10GbE SFP subcommands */
> XGBE_MB_SUBCMD_ACTIVE = 0,
> @@ -1316,6 +1317,10 @@ struct xgbe_prv_data {
>
> bool debugfs_an_cdr_workaround;
> bool debugfs_an_cdr_track_early;
> + bool en_rx_adap;
nit: there is a 1 byte hole here (on x86_64)
> + int rx_adapt_retries;
> + bool rx_adapt_done;
> + bool mode_set;
> };
>
> /* Function prototypes*/
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-02-01 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 5:49 [PATCH net-next v2 0/2] amd-xgbe: add support for 2.5GbE and rx-adaptation Raju Rangoju
2023-02-01 5:49 ` [PATCH net-next v2 1/2] amd-xgbe: add 2.5GbE support to 10G BaseT mode Raju Rangoju
2023-02-01 5:49 ` [PATCH net-next v2 2/2] amd-xgbe: add support for rx-adaptation Raju Rangoju
2023-02-01 17:11 ` Simon Horman [this message]
2023-02-02 14:16 ` Paolo Abeni
2023-02-03 8:09 ` Simon Horman
2023-02-03 8:19 ` Raju Rangoju
2023-02-04 13:11 ` Simon Horman
2023-02-02 14:30 ` [PATCH net-next v2 0/2] amd-xgbe: add support for 2.5GbE and rx-adaptation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9qdRsS5txwu3MND@corigine.com \
--to=simon.horman@corigine.com \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).