From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ED4C433E0 for ; Thu, 14 Jan 2021 23:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B753223A6C for ; Thu, 14 Jan 2021 23:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731001AbhANXBX (ORCPT ); Thu, 14 Jan 2021 18:01:23 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:41636 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730929AbhANXBW (ORCPT ); Thu, 14 Jan 2021 18:01:22 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l0BbV-000eLv-5M; Fri, 15 Jan 2021 00:00:33 +0100 Date: Fri, 15 Jan 2021 00:00:33 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, pavana.sharma@digi.com, vivien.didelot@gmail.com, f.fainelli@gmail.com, kuba@kernel.org, lkp@intel.com, davem@davemloft.net, ashkan.boldaji@digi.com, Chris Packham , olteanv@gmail.com, Russell King - ARM Linux admin , Russell King Subject: Re: [PATCH net] net: dsa: mv88e6xxx: do not allow inband AN for 2500base-x mode Message-ID: References: <20210114024055.17602-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210114024055.17602-1-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c > index 3195936dc5be..b8241820679e 100644 > --- a/drivers/net/dsa/mv88e6xxx/serdes.c > +++ b/drivers/net/dsa/mv88e6xxx/serdes.c > @@ -55,9 +55,20 @@ static int mv88e6xxx_serdes_pcs_get_state(struct mv88e6xxx_chip *chip, > { > if (status & MV88E6390_SGMII_PHY_STATUS_SPD_DPL_VALID) { > state->link = !!(status & MV88E6390_SGMII_PHY_STATUS_LINK); > + > + if (state->interface == PHY_INTERFACE_MODE_2500BASEX) { > + if (state->link) { > + state->speed = SPEED_2500; > + state->duplex = DUPLEX_FULL; > + } > + > + return 0; > + } > + > + state->an_complete = 1; Should this be here? It seems like a logically different change, it is not clear to me it is to do with PHY_INTERFACE_MODE_2500BASEX. > state->duplex = status & > MV88E6390_SGMII_PHY_STATUS_DUPLEX_FULL ? > - DUPLEX_FULL : DUPLEX_HALF; > + DUPLEX_FULL : DUPLEX_HALF; This looks like an unintended white space change. Andrew