From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D37C433E0 for ; Mon, 1 Feb 2021 01:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9A2E64DCC for ; Mon, 1 Feb 2021 01:45:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbhBABos (ORCPT ); Sun, 31 Jan 2021 20:44:48 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40610 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbhBABoo (ORCPT ); Sun, 31 Jan 2021 20:44:44 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l6OFx-003Z9c-1A; Mon, 01 Feb 2021 02:43:57 +0100 Date: Mon, 1 Feb 2021 02:43:57 +0100 From: Andrew Lunn To: Vadim Pasternak Cc: Jiri Pirko , David Ahern , Jakub Kicinski , "netdev@vger.kernel.org" , "davem@davemloft.net" , "jacob.e.keller@intel.com" , Roopa Prabhu , mlxsw Subject: Re: [patch net-next RFC 00/10] introduce line card support for modular switch Message-ID: References: <20210126113326.GO3565223@nanopsycho.orion> <20210127075753.GP3565223@nanopsycho.orion> <20210128081434.GV3565223@nanopsycho.orion> <20210129072015.GA4652@nanopsycho.orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Platform line card driver is aware of line card I2C topology, its > responsibility is to detect line card basic hardware type, create I2C > topology (mux), connect all the necessary I2C devices, like hotswap > devices, voltage and power regulators devices, iio/a2d devices and line > card EEPROMs, creates LED instances for LED located on a line card, exposes > line card related attributes, like CPLD and FPGA versions, reset causes, > required powered through line card hwmon interface. Jiri says the hardware is often connected to the BMC. But you do expose much of this to the host as well? You want devlink dev info to show the version information. Use devlink dev flash to upgrade the bitfile in the CPD and FPGA. The hwmon instances are pretty pointless on the BMC where nobody can see them. Are there temperature sensors involved? The host is where the thermal policy is running, deciding what to throttle, or shut down when it gets too hot. LEDs can be controlled via /sys/class/led as expected? So exporting what the line card actually is to the host is not really a problem, it is just one more bit of information amongst everything else already exposed to it. Andrew