From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 196E4C432C3 for ; Thu, 18 Feb 2021 11:08:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB5E860C3D for ; Thu, 18 Feb 2021 11:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232421AbhBRLGB (ORCPT ); Thu, 18 Feb 2021 06:06:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:57182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbhBRKiE (ORCPT ); Thu, 18 Feb 2021 05:38:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 768DF64DE9; Thu, 18 Feb 2021 10:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613644633; bh=GC/+qGL4jWqb0AlBV+rnFjuMEIRv27x+lfUlOQ/3QCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LHZywTMg4ggnBnh7h4rxOOyA9sZaj0kObrbRX3ik6J89xnZQYGoj0GVy/YFtS/BIf eFOP4g90bnhdKzcv4HQTF0x5WOJgJSkKGor9AT7lQyMyzD+RX9sRitFY9BsV4eFP2Z hL6MC4Ps52qUO/P5Mz7p7IYe139BtyTv8LTLsx5rtQaMmlW9oMOk1Q8lW/Xi07xgnb HHRz2QU/vC1lEvtkpf4aPCNAxJq56ysa0w+wgpB6Qi815ploMBwk86E6pUZxGP5bFf Gwdovi+95e3ZsKIbzW0aex+m2WLwo6GCg6vLLXiCQubvVc5YGXQ9KQUP0EfqL5CN8i 2ZlX6yAM/EL6A== Date: Thu, 18 Feb 2021 12:37:09 +0200 From: Leon Romanovsky To: Xie He Cc: "David S. Miller" , Jakub Kicinski , Linux X25 , Linux Kernel Network Developers , LKML , Martin Schiller , Krzysztof Halasa , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames Message-ID: References: <20210216201813.60394-1-xie.he.0141@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 18, 2021 at 01:07:13AM -0800, Xie He wrote: > On Thu, Feb 18, 2021 at 12:57 AM Leon Romanovsky wrote: > > > > It is nice that you are resending your patch without the resolution. > > However it will be awesome if you don't ignore review comments and fix this "3 - 1" > > by writing solid comment above. > > I thought you already agreed with me? It looks like you didn't? > > I still don't think there is any problem with my current way. > > I still don't understand your point. What problem do you think is > there? Why is your way better than my way? I've already given multiple > reasons about why my way is better than yours. But you didn't explain > clearly why yours is better than mine. It is not me who didn't explain, it is you who didn't want to write clear comment that describes the headroom size without need of "3 - 1". So in current situation, you added two things: comment and assignment. Both of them aren't serve their goals. Your comment doesn't explain enough and needs extra help and your assignment is useless without comment. Thanks