From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD79C433DB for ; Thu, 18 Feb 2021 19:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFB7E64EB4 for ; Thu, 18 Feb 2021 19:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbhBRTyj (ORCPT ); Thu, 18 Feb 2021 14:54:39 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47998 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230368AbhBRTvJ (ORCPT ); Thu, 18 Feb 2021 14:51:09 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lCpJc-007AO5-TG; Thu, 18 Feb 2021 20:50:20 +0100 Date: Thu, 18 Feb 2021 20:50:20 +0100 From: Andrew Lunn To: Grant Grundler Cc: Oliver Neukum , netdev , davem@devemloft.org, Hayes Wang , Jakub Kicinski , Roland Dreier Subject: Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings Message-ID: References: <20210218102038.2996-1-oneukum@suse.com> <20210218102038.2996-2-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 18, 2021 at 07:31:41PM +0000, Grant Grundler wrote: > Oliver, Jakub, > Can I post v4 and deal with the issues below? You should probably wait for two weeks. We are far enough into the merge window that i doubt it will get picked up. So please wait, rebase, and then post. > Nit: The v2/v3 lines should be included BELOW the '---' line since > they don't belong in the commit message. netdev actually prefers them above, so we see the history of how a patched changed during review. Andrew