netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: mingo@redhat.com, will@kernel.org, kvalo@codeaurora.org,
	davem@davemloft.net, kuba@kernel.org, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] lockdep: add lockdep_assert_not_held()
Date: Sun, 14 Feb 2021 18:53:01 +0100	[thread overview]
Message-ID: <YCljfeNr4m5mZa4N@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <37a29c383bff2fb1605241ee6c7c9be3784fb3c6.1613171185.git.skhan@linuxfoundation.org>

On Fri, Feb 12, 2021 at 04:28:42PM -0700, Shuah Khan wrote:

> +#define lockdep_assert_not_held(l)	do {			\
> +		WARN_ON(debug_locks && lockdep_is_held(l));	\
> +	} while (0)
> +

This thing isn't as straight forward as you might think, but it'll
mostly work.

Notably this thing will misfire when lockdep_off() is employed. It
certainyl needs a comment to explain the subtleties.

  reply	other threads:[~2021-02-14 17:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 23:28 [PATCH 0/2] Add lockdep_assert_not_held() Shuah Khan
2021-02-12 23:28 ` [PATCH 1/2] lockdep: add lockdep_assert_not_held() Shuah Khan
2021-02-14 17:53   ` Peter Zijlstra [this message]
2021-02-15 10:44     ` Peter Zijlstra
2021-02-15 13:12       ` Johannes Berg
2021-02-15 16:04         ` Peter Zijlstra
2021-02-15 16:10           ` Johannes Berg
2021-02-22 20:51             ` Shuah Khan
2021-02-12 23:28 ` [PATCH 2/2] ath10k: detect conf_mutex held ath10k_drain_tx() calls Shuah Khan
2021-02-14  6:08   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCljfeNr4m5mZa4N@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ath10k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).