From: Leon Romanovsky <leon@kernel.org>
To: Hao Chen <chenhaoa@uniontech.com>
Cc: tony0620emma@gmail.com, kvalo@codeaurora.org,
davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop
Date: Sun, 21 Feb 2021 08:51:25 +0200 [thread overview]
Message-ID: <YDIC7RGqq5sFA0pG@unreal> (raw)
In-Reply-To: <20210220084602.22386-1-chenhaoa@uniontech.com>
On Sat, Feb 20, 2021 at 04:46:02PM +0800, Hao Chen wrote:
> When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't
> resume.
> The dmesg of kernel report:
> "[ 99.990168] pcieport 0000:00:01.2: can't change power state
> from D3hot to D0 (config space inaccessible)
> [ 99.993334] rtw_pci 0000:01:00.0: can't change power state
> from D3hot to D0 (config space inaccessible)
> [ 104.435004] rtw_pci 0000:01:00.0: mac power on failed
> [ 104.435010] rtw_pci 0000:01:00.0: failed to power on mac"
> When try to pointer the driver.pm to NULL, the problem is fixed.
> This driver hasn't implemented pm ops yet.It makes the sleep and
> wake procedure expected when pm's ops not NULL.
>
> Fixed: commit e3037485c68e ("rtw88: new Realtek 802.11ac driver")
>
> Signed-off-by: Hao Chen <chenhaoa@uniontech.com>
> ---
> drivers/net/wireless/realtek/rtw88/rtw8822ce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
> index 3845b1333dc3..b4c6762ba7ac 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
> @@ -25,7 +25,7 @@ static struct pci_driver rtw_8822ce_driver = {
> .id_table = rtw_8822ce_id_table,
> .probe = rtw_pci_probe,
> .remove = rtw_pci_remove,
> - .driver.pm = &rtw_pm_ops,
> + .driver.pm = NULL,
The NULL is the default, it is enough to delete ".driver.pm = &rtw_pm_ops," line.
Thanks
> .shutdown = rtw_pci_shutdown,
> };
> module_pci_driver(rtw_8822ce_driver);
> --
> 2.20.1
>
>
>
prev parent reply other threads:[~2021-02-21 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 8:46 [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop Hao Chen
2021-02-20 9:07 ` Kalle Valo
[not found] ` <1323517535.1654941.1613976259730.JavaMail.xmail@bj-wm-cp-15>
2021-02-22 7:27 ` Kalle Valo
2021-02-22 11:20 ` Pkshih
2021-02-22 12:36 ` Hao Chen
2021-02-21 6:51 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDIC7RGqq5sFA0pG@unreal \
--to=leon@kernel.org \
--cc=chenhaoa@uniontech.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).