From: Greg KH <gregkh@linuxfoundation.org>
To: "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
Gage Eads <gage.eads@intel.com>
Subject: Re: [PATCH v10 03/20] dlb: add resource and device initialization
Date: Wed, 10 Mar 2021 09:13:24 +0100 [thread overview]
Message-ID: <YEh/pKVV36r2rbAr@kroah.com> (raw)
In-Reply-To: <BYAPR11MB3095C06792321F64E98394FCD9919@BYAPR11MB3095.namprd11.prod.outlook.com>
On Wed, Mar 10, 2021 at 01:33:24AM +0000, Chen, Mike Ximing wrote:
>
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> >
> > On Wed, Feb 10, 2021 at 11:54:06AM -0600, Mike Ximing Chen wrote:
> > > +
> > > +#include "dlb_bitmap.h"
> > > +
> > > +#define BITS_SET(x, val, mask) (x = ((x) & ~(mask)) \
> > > + | (((val) << (mask##_LOC)) & (mask)))
> > > +#define BITS_GET(x, mask) (((x) & (mask)) >> (mask##_LOC))
> >
> > Why not use the built-in kernel functions for this? Why are you
> > creating your own?
> >
> FIELD_GET(_mask, _val) and FIELD_PREP(_mask, _val) in include/linux/bitfield.h
> are similar to our BITS_GET() and BITS_SET(). However in our case, mask##_LOC
> is a known constant defined in dlb_regs.h, so we don't need to use
> _buildin_ffs(mask) to calculate the location of mask as FIELD_GET() and FIELD_PREP()
> do. We can still use FIELD_GET and FIELD_PREP, but our macros are a little more
> efficient. Would it be OK to keep them?
No, please use the kernel-wide proper functions, there's no need for
single tiny driver to be "special" in this regard. If somehow the
in-kernel functions are not sufficient, it's always better to fix them
up than to go your own way here.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-10 8:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 17:54 [PATCH v10 00/20] dlb: introduce DLB device driver Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 01/20] dlb: add skeleton for DLB driver Mike Ximing Chen
2021-02-18 7:34 ` Chen, Mike Ximing
2021-02-18 7:52 ` gregkh
2021-02-18 15:37 ` Chen, Mike Ximing
2021-03-07 13:59 ` Chen, Mike Ximing
2021-02-10 17:54 ` [PATCH v10 02/20] dlb: initialize device Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 03/20] dlb: add resource and device initialization Mike Ximing Chen
2021-03-09 9:24 ` Greg KH
2021-03-10 1:33 ` Chen, Mike Ximing
2021-03-10 8:13 ` Greg KH [this message]
2021-03-10 20:26 ` Chen, Mike Ximing
2021-02-10 17:54 ` [PATCH v10 04/20] dlb: add device ioctl layer and first three ioctls Mike Ximing Chen
2021-03-09 9:26 ` Greg KH
2021-03-10 1:34 ` Chen, Mike Ximing
2021-02-10 17:54 ` [PATCH v10 05/20] dlb: add scheduling domain configuration Mike Ximing Chen
2021-03-09 9:28 ` Greg KH
2021-03-10 1:35 ` Chen, Mike Ximing
2021-02-10 17:54 ` [PATCH v10 06/20] dlb: add domain software reset Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 07/20] dlb: add low-level register reset operations Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 08/20] dlb: add runtime power-management support Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 09/20] dlb: add queue create, reset, get-depth ioctls Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 10/20] dlb: add register operations for queue management Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 11/20] dlb: add ioctl to configure ports and query poll mode Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 12/20] dlb: add register operations for port management Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 13/20] dlb: add port mmap support Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 14/20] dlb: add start domain ioctl Mike Ximing Chen
2021-03-09 9:29 ` Greg KH
2021-03-10 2:45 ` Chen, Mike Ximing
2021-03-10 8:14 ` Greg KH
2021-03-10 20:19 ` Dan Williams
2021-03-10 20:26 ` Chen, Mike Ximing
2021-02-10 17:54 ` [PATCH v10 15/20] dlb: add queue map, unmap, and pending unmap operations Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 16/20] dlb: add port map/unmap state machine Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 17/20] dlb: add static queue map register operations Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 18/20] dlb: add dynamic " Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 19/20] dlb: add queue unmap " Mike Ximing Chen
2021-02-10 17:54 ` [PATCH v10 20/20] dlb: queue map/unmap workqueue Mike Ximing Chen
2021-03-10 9:02 ` [PATCH v10 00/20] dlb: introduce DLB device driver Greg KH
2021-03-12 7:18 ` Dan Williams
2021-03-12 21:55 ` Chen, Mike Ximing
2021-03-13 1:39 ` Dan Williams
2021-03-15 20:04 ` Chen, Mike Ximing
2021-03-15 20:08 ` Chen, Mike Ximing
2021-03-15 20:18 ` Chen, Mike Ximing
2021-03-16 9:01 ` Greg KH
2021-05-12 19:07 ` Dan Williams
2021-05-14 14:33 ` Greg KH
2021-07-16 1:04 ` Chen, Mike Ximing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEh/pKVV36r2rbAr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=gage.eads@intel.com \
--cc=kuba@kernel.org \
--cc=mike.ximing.chen@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).