From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F15C433B4 for ; Wed, 7 Apr 2021 01:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31AC861382 for ; Wed, 7 Apr 2021 01:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347662AbhDGBH5 (ORCPT ); Tue, 6 Apr 2021 21:07:57 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37284 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233073AbhDGBH4 (ORCPT ); Tue, 6 Apr 2021 21:07:56 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lTwfY-00FE5I-0a; Wed, 07 Apr 2021 03:07:44 +0200 Date: Wed, 7 Apr 2021 03:07:44 +0200 From: Andrew Lunn To: Dexuan Cui Cc: davem@davemloft.net, kuba@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, liuwe@microsoft.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA) Message-ID: References: <20210406232321.12104-1-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406232321.12104-1-decui@microsoft.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static int gdma_query_max_resources(struct pci_dev *pdev) > +{ > + struct gdma_context *gc = pci_get_drvdata(pdev); > + struct gdma_general_req req = { 0 }; > + struct gdma_query_max_resources_resp resp = { 0 }; > + int err; Network drivers need to use reverse christmas tree. I spotted a number of functions getting this wrong. Please review the whole driver. > + > + gdma_init_req_hdr(&req.hdr, GDMA_QUERY_MAX_RESOURCES, > + sizeof(req), sizeof(resp)); > + > + err = gdma_send_request(gc, sizeof(req), &req, sizeof(resp), &resp); > + if (err || resp.hdr.status) { > + pr_err("%s, line %d: err=%d, err=0x%x\n", __func__, __LINE__, > + err, resp.hdr.status); I expect checkpatch complained about this. Don't use pr_err(), use dev_err(pdev->dev, ... of netdev_err(ndev, ... You should always have access to dev or ndev, so please change all pr_ calls. > +static unsigned int num_queues = ANA_DEFAULT_NUM_QUEUE; > +module_param(num_queues, uint, 0444); No module parameters please. Andrew