From: Andrew Lunn <andrew@lunn.ch>
To: Danielle Ratson <danieller@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
alobakin@pm.me, meirl@mellanox.com, dmurphy@ti.com,
mkubecek@suse.cz, f.fainelli@gmail.com, irusskikh@marvell.com,
alexanderduyck@fb.com, magnus.karlsson@intel.com,
ecree@solarflare.com, idosch@nvidia.com, jiri@nvidia.com,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file
Date: Thu, 8 Apr 2021 15:49:52 +0200 [thread overview]
Message-ID: <YG8KAOtjkpNuEPkN@lunn.ch> (raw)
In-Reply-To: <20210408105813.2555878-1-danieller@nvidia.com>
On Thu, Apr 08, 2021 at 01:58:13PM +0300, Danielle Ratson wrote:
> __ethtool_get_link_ksettings() function is shared by both ioctl and
> netlink ethtool interfaces.
>
> Move it to net/ethtool/common.c file, which is the suitable place for
> a shared code.
>
> Signed-off-by: Danielle Ratson <danieller@nvidia.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Seems sensible.
Did you look to see what else is shared and should move? Rather than
doing it one function at a time, can we do it all at once?
Andrew
next prev parent reply other threads:[~2021-04-08 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:58 [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file Danielle Ratson
2021-04-08 13:49 ` Andrew Lunn [this message]
2021-04-22 15:38 ` Danielle Ratson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG8KAOtjkpNuEPkN@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexanderduyck@fb.com \
--cc=alobakin@pm.me \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=ecree@solarflare.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=irusskikh@marvell.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=meirl@mellanox.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).