From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7E09C433B4 for ; Thu, 8 Apr 2021 13:50:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A23E361164 for ; Thu, 8 Apr 2021 13:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231924AbhDHNuR (ORCPT ); Thu, 8 Apr 2021 09:50:17 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40428 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231892AbhDHNuM (ORCPT ); Thu, 8 Apr 2021 09:50:12 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lUV2e-00FWgV-WB; Thu, 08 Apr 2021 15:49:52 +0200 Date: Thu, 8 Apr 2021 15:49:52 +0200 From: Andrew Lunn To: Danielle Ratson Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, alobakin@pm.me, meirl@mellanox.com, dmurphy@ti.com, mkubecek@suse.cz, f.fainelli@gmail.com, irusskikh@marvell.com, alexanderduyck@fb.com, magnus.karlsson@intel.com, ecree@solarflare.com, idosch@nvidia.com, jiri@nvidia.com, mlxsw@nvidia.com Subject: Re: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file Message-ID: References: <20210408105813.2555878-1-danieller@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408105813.2555878-1-danieller@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 08, 2021 at 01:58:13PM +0300, Danielle Ratson wrote: > __ethtool_get_link_ksettings() function is shared by both ioctl and > netlink ethtool interfaces. > > Move it to net/ethtool/common.c file, which is the suitable place for > a shared code. > > Signed-off-by: Danielle Ratson > Suggested-by: Jakub Kicinski > Reviewed-by: Ido Schimmel > Reviewed-by: Jiri Pirko Seems sensible. Did you look to see what else is shared and should move? Rather than doing it one function at a time, can we do it all at once? Andrew