From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Leon Romanovsky <leonro@nvidia.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
nic_swsd@realtek.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v4 0/3] PCI: Disable parity checking
Date: Wed, 31 Mar 2021 13:26:11 +0200 [thread overview]
Message-ID: <YGRcU8esaSxq45aT@rocinante> (raw)
In-Reply-To: <20210330174318.1289680-1-helgaas@kernel.org>
Hi Bjorn,
> I think this is essentially the same as Heiner's v3 posting, with these
> changes:
>
> - Added a pci_disable_parity() interface in pci.c instead of making a
> public pci_quirk_broken_parity() because quirks.c is only compiled when
> CONFIG_PCI_QUIRKS=y.
Very nice idea to add pci_disable_parity(), looks very clean.
> - Removed the setting of dev->broken_parity_status because it's really
> only used by EDAC error reporting, and if we disable parity error
> reporting, we shouldn't get there. This change will be visible in the
> sysfs "broken_parity_status" file, but I doubt that's important.
>
> I dropped Leon's reviewed-by because I fiddled with the code. Similarly I
> haven't added your signed-off-by, Heiner, because I don't want you blamed
> for my errors. But if this looks OK to you I'll add it.
[...]
Thank you Bjorn and Heiner!
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
prev parent reply other threads:[~2021-03-31 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:43 [PATCH v4 0/3] PCI: Disable parity checking Bjorn Helgaas
2021-03-30 17:43 ` [PATCH v4 1/3] PCI: Add pci_disable_parity() Bjorn Helgaas
2021-03-30 17:43 ` [PATCH v4 2/3] IB/mthca: Disable parity reporting Bjorn Helgaas
2021-03-30 17:43 ` [PATCH v4 3/3] ARM: iop32x: disable N2100 PCI " Bjorn Helgaas
2021-03-31 11:08 ` [PATCH v4 0/3] PCI: Disable parity checking Heiner Kallweit
2021-03-31 11:26 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGRcU8esaSxq45aT@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).