From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1903AC433B4 for ; Mon, 12 Apr 2021 07:40:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAC886121D for ; Mon, 12 Apr 2021 07:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236920AbhDLHkk (ORCPT ); Mon, 12 Apr 2021 03:40:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:42268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236916AbhDLHkb (ORCPT ); Mon, 12 Apr 2021 03:40:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C96AC61207; Mon, 12 Apr 2021 07:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618213213; bh=PqrprxM8ruC8Y4nAdtK1y3AXp+UT48yE/rDrzpZ44oU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ncs5gZO/GAf5MDEh/R3yMagsLX7kDlGoouwqzw8qOslxulyMdY5Yd3I5CyWjSTkl7 6OYjdro6AdnpMiX/lDHCcIh1NHzxUm0z7Ybm03Heo3I28vjHBwEGQqcY5jsg4dY88e idt0/9jj7VTEtPuo+pwSTdwZCqgoEEbQwdVfmHXPekRVIFPiZbaNFM8+cGNzvbN4z2 w7FunmfAnnEfpQ18Zty4kEiGT63+POKsY1z55WMaRlwB2q8uPEVlWcZsaZ9KdkGo2j ehIWzUmJkOdqrL/N3aO4zNGFqLVrz/wHinCgcz8ZOLnaTuorlmmDLftb47YvMCoLmw 6u7SfpoYo+jcw== Date: Mon, 12 Apr 2021 10:40:09 +0300 From: Leon Romanovsky To: Devesh Sharma Cc: Jason Gunthorpe , Doug Ledford , "David S. Miller" , Jakub Kicinski , linux-rdma , Michael Chan , Naresh Kumar PBS , Netdev , Selvin Xavier , Somnath Kotur , Sriharsha Basavapatna Subject: Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency Message-ID: References: <20210401065715.565226-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote: > On Thu, Apr 8, 2021 at 5:14 PM Leon Romanovsky wrote: > > > > On Thu, Apr 08, 2021 at 05:06:24PM +0530, Devesh Sharma wrote: > > > On Sat, Apr 3, 2021 at 5:12 PM Leon Romanovsky wrote: > > > > > > > > On Sat, Apr 03, 2021 at 03:52:13PM +0530, Devesh Sharma wrote: > > > > > On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky wrote: > > > > > > > > > > > > From: Leon Romanovsky > > > > > > > > > > > > Changelog: > > > > > > v2: > > > > > > * kbuild spotted that I didn't delete all code in patch #5, so deleted > > > > > > even more ulp_ops derefences. > > > > > > v1: https://lore.kernel.org/linux-rdma/20210329085212.257771-1-leon@kernel.org > > > > > > * Go much deeper and removed useless ULP indirection > > > > > > v0: https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org > > > > > > ----------------------------------------------------------------------- > > > > > > > > > > > > The following series fixes issue spotted in [1], where bnxt_re driver > > > > > > messed with module reference counting in order to implement symbol > > > > > > dependency of bnxt_re and bnxt modules. All of this is done, when in > > > > > > upstream we have only one ULP user of that bnxt module. The simple > > > > > > declaration of exported symbol would do the trick. > > > > > > > > > > > > This series removes that custom module_get/_put, which is not supposed > > > > > > to be in the driver from the beginning and get rid of nasty indirection > > > > > > logic that isn't relevant for the upstream code. > > > > > > > > > > > > Such small changes allow us to simplify the bnxt code and my hope that > > > > > > Devesh will continue where I stopped and remove struct bnxt_ulp_ops too. > > > > > > > > > > > > Thanks > > > > > > > > > > > > [1] https://lore.kernel.org/linux-rdma/20210324142524.1135319-1-leon@kernel.org > > > > > > > > > > > > Leon Romanovsky (5): > > > > > > RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it > > > > > > RDMA/bnxt_re: Create direct symbolic link between bnxt modules > > > > > > RDMA/bnxt_re: Get rid of custom module reference counting > > > > > > net/bnxt: Remove useless check of non-existent ULP id > > > > > > net/bnxt: Use direct API instead of useless indirection > > > > > > > > > > > > drivers/infiniband/hw/bnxt_re/Kconfig | 4 +- > > > > > > drivers/infiniband/hw/bnxt_re/main.c | 93 ++----- > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +- > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 245 +++++++----------- > > > > > > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 32 +-- > > > > > > 6 files changed, 119 insertions(+), 260 deletions(-) > > > > > > > > > > Hi Leon, > > > > > > > > > > After a couple of internal discussions we reached a conclusion to > > > > > implement the Auxbus driver interface and fix the problem once and for > > > > > all. > > > > > > > > Thanks Devesh, > > > > > > > > Jason, it looks like we can proceed with this patchset, because in > > > > auxbus mode this module refcount and ULP indirection logics will be > > > > removed anyway. > > > > > > > > Thanks > > > Hi Leon, > > > > > > In my internal testing, I am seeing a crash using the 3rd patch. I am > > > spending a few cycles on debugging it. expect my input in a day or so. > > > > Can you please post the kernel crash report here? > > I don't see how function rename in patch #3 can cause to the crash. > Hey, unfortunately my kdump service config is giving me tough time on > my host. I will share if I get it. Any news here? > > > > Thanks > > > > > > > > > > > > > > > > > > -- > > > > > > 2.30.2 > > > > > > > > > > > > > > > > > > > > > -- > > > > > -Regards > > > > > Devesh > > > > > > > > > > > > > > > > > -- > > > -Regards > > > Devesh > > > > > > > -- > -Regards > Devesh