From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E196EC43461 for ; Wed, 21 Apr 2021 13:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B34FA61453 for ; Wed, 21 Apr 2021 13:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242540AbhDUNei (ORCPT ); Wed, 21 Apr 2021 09:34:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:48752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235588AbhDUNeh (ORCPT ); Wed, 21 Apr 2021 09:34:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8546161449; Wed, 21 Apr 2021 13:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619012044; bh=4k+3XsmvhTwItuQS7ASo+R/yH2hxOaxaEo+U/U0QH/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qttmIBdSLiFBQ13ZleEC5e15kCiD8LSCqN5dnCyOpBXvpp2ZWfknVwfbvad1IMpfi B2E7FchubxZhfT7uEQBac79LxhXEBPIcjJkqLu5bDTo5lOua6HLB2X0Zf05KssXLdN xIRt9kIcTo5Vz7FF8WOdzmDg+WvhkShi/ETffqI8MsVKP3O/L6N0WUdCZ6jZ5gMlHC eiWk6Pg6ygib+foGevry08qh6a7yqWCKQaX1q/pCoJzVvCXk1rInYRsgPp0AwwUHim rqTMTfD6relnvKt8SdC4Z5teH2BzgmdsH75h3+y8dVKbss/ZhZ44/cBBmfGMQ6bcho ZRhB8TgtBTHvg== Date: Wed, 21 Apr 2021 16:34:00 +0300 From: Leon Romanovsky To: "gregkh@linuxfoundation.org" Cc: Trond Myklebust , "a.shelat@northeastern.edu" , "davem@davemloft.net" , "chuck.lever@oracle.com" , "dwysocha@redhat.com" , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "sudipm.mukherjee@gmail.com" , "bfields@fieldses.org" , "anna.schumaker@netapp.com" , "pakki001@umn.edu" , "linux-nfs@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] SUNRPC: Add a check for gss_release_msg Message-ID: References: <20210420171008.GB4017@fieldses.org> <3B9A54F7-6A61-4A34-9EAC-95332709BAE7@northeastern.edu> <6530850bc6f0341d1f2d5043ba1dd04e242cff66.camel@hammerspace.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 21, 2021 at 03:21:15PM +0200, gregkh@linuxfoundation.org wrote: > On Wed, Apr 21, 2021 at 01:11:03PM +0000, Trond Myklebust wrote: > > On Wed, 2021-04-21 at 15:19 +0300, Leon Romanovsky wrote: > > > On Wed, Apr 21, 2021 at 11:58:08AM +0000, Shelat, Abhi wrote: > > > > > > > > > > > > > > They introduce kernel bugs on purpose. Yesterday, I took a > > > > > > > > look on 4 > > > > > > > > accepted patches from Aditya and 3 of them added various > > > > > > > > severity security > > > > > > > > "holes". > > > > > > > > > > > > > > All contributions by this group of people need to be > > > > > > > reverted, if they > > > > > > > have not been done so already, as what they are doing is > > > > > > > intentional > > > > > > > malicious behavior and is not acceptable and totally > > > > > > > unethical.  I'll > > > > > > > look at it after lunch unless someone else wants to do it… > > > > > > > > > > > > > > > > > > > > > > Academic research should NOT waste the time of a community. > > > > > > > > If you believe this behavior deserves an escalation, you can > > > > contact the Institutional Review Board (irb@umn.edu) at UMN to > > > > investigate whether this behavior was harmful; in particular, > > > > whether the research activity had an appropriate IRB review, and > > > > what safeguards prevent repeats in other communities. > > > > > > The huge advantage of being "community" is that we don't need to do > > > all > > > the above and waste our time to fill some bureaucratic forms with > > > unclear > > > timelines and results. > > > > > > Our solution to ignore all @umn.edu contributions is much more > > > reliable > > > to us who are suffering from these researchers. > > > > > > > That's an easy thing to sidestep by just shifting to using a > > private email address. > > If they just want to be jerks, yes. But they can't then use that type > of "hiding" to get away with claiming it was done for a University > research project as that's even more unethical than what they are doing > now. > > > There really is no alternative for maintainers other than to always be > > sceptical of patches submitted by people who are not known and trusted > > members of the community, and to scrutinise those patches with more > > care. > > Agreed, and when we notice things like this that were determined to be > bad, we have the ability to easily go back and rip the changes out and > we can slowly add them back if they are actually something we want to > do. > > Which is what I just did: > https://lore.kernel.org/lkml/20210421130105.1226686-1-gregkh@linuxfoundation.org/ Greg, Did you push your series to the public git? I would like to add you a couple of reverts. And do you have a list of not reverted commits? It will save us from doing same comparison of reverted/not reverted over and over. Thanks > > thanks, > > greg k-h