From: Andrew Lunn <andrew@lunn.ch>
To: Maxim Kochetkov <fido_max@inbox.ru>
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
f.fainelli@gmail.com
Subject: Re: [PATCH 1/1] net: phy: marvell: enable downshift by default
Date: Thu, 29 Apr 2021 23:50:44 +0200 [thread overview]
Message-ID: <YIsqNMYKD0gsg/q5@lunn.ch> (raw)
In-Reply-To: <20210428124853.926179-1-fido_max@inbox.ru>
On Wed, Apr 28, 2021 at 03:48:53PM +0300, Maxim Kochetkov wrote:
> Enable downshift for all supported PHYs by default like 88E1116R does.
Hi Maxim
Please expand the commit message. It does not explain enough, which is
why i asked the odd question. Maybe something like:
A number of PHYs support the PHY tunable to set and get
downshift. However, only 88E1116R enables downshift by default. Extend
this default enabled to all the PHYs that support the downshift
tunable.
Andrew
prev parent reply other threads:[~2021-04-29 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 12:48 [PATCH 1/1] net: phy: marvell: enable downshift by default Maxim Kochetkov
2021-04-28 19:30 ` Andrew Lunn
2021-04-29 3:52 ` Maxim Kochetkov
2021-04-29 21:50 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIsqNMYKD0gsg/q5@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).