From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C5CDC433B4 for ; Fri, 30 Apr 2021 16:34:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F72161420 for ; Fri, 30 Apr 2021 16:34:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbhD3Qfp (ORCPT ); Fri, 30 Apr 2021 12:35:45 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48202 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbhD3Qfo (ORCPT ); Fri, 30 Apr 2021 12:35:44 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lcW6H-001pzm-9A; Fri, 30 Apr 2021 18:34:45 +0200 Date: Fri, 30 Apr 2021 18:34:45 +0200 From: Andrew Lunn To: Frank Wunderlich Cc: DENG Qingfang , David Miller , f.fainelli@gmail.com, hkallweit1@gmail.com, kuba@kernel.org, Landen.Chao@mediatek.com, matthias.bgg@gmail.com, linux@armlinux.org.uk, sean.wang@mediatek.com, vivien.didelot@gmail.com, olteanv@gmail.com, robh+dt@kernel.org, linus.walleij@linaro.org, gregkh@linuxfoundation.org, sergio.paracuellos@gmail.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, netdev@vger.kernel.org, weijie.gao@mediatek.com, gch981213@gmail.com, opensource@vdorst.com, tglx@linutronix.de, maz@kernel.org Subject: Re: Re: Re: Re: [PATCH net-next 0/4] MT7530 interrupt support Message-ID: References: <20210429062130.29403-1-dqfext@gmail.com> <20210429.170815.956010543291313915.davem@davemloft.net> <20210430023839.246447-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > mhm, maybe the naming should differ if generic phy and net-phy are > that different. i guess there is no way to merge the net phys to the > generic phys (due to linking to the net device drivers) to have only > 1 phy section, right? phys and generic PHYs are very different things, completely different API etc. They cannot be merged. > but if phy- prefix is used by generic phys, maybe eth- or net- can be used here (maybe with "phy" added) > > something like > > eth-phy-mt753x.ko > > else i have no idea now...my patch renaming the musb-module seems not > to be accepted due to possible breakage The usb module has been around for a long time, so it cannot be changed. The phy driver is new, not in a released kernel. So we can still rename it without causing problems. I still want to understand the naming here. If you look at most Ethernet switches with integrated PHYs, the PHYs have their own naming scheme, separate from the switch, because they are independent IP. So i would prefer this driver by named after the PHY name, not the switch name. That might solve the naming conflict, mt123x for the PHY, mt7530 for the switch driver. Andrew