From: Leon Romanovsky <leon@kernel.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: Or Cohen <orcohen@paloaltonetworks.com>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
nixiaoming@huawei.com, matthieu.baerts@tessares.net,
mkl@pengutronix.de, nmarkus@paloaltonetworks.com
Subject: Re: [PATCH] net/nfc: fix use-after-free llcp_sock_bind/connect
Date: Wed, 5 May 2021 07:50:12 +0300 [thread overview]
Message-ID: <YJIkBH/9kb6SMRh/@unreal> (raw)
In-Reply-To: <162015541015.23495.4578937039249917498.git-patchwork-notify@kernel.org>
On Tue, May 04, 2021 at 07:10:10PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net.git (refs/heads/master):
>
> On Tue, 4 May 2021 10:16:46 +0300 you wrote:
> > Commits 8a4cd82d ("nfc: fix refcount leak in llcp_sock_connect()")
> > and c33b1cc62 ("nfc: fix refcount leak in llcp_sock_bind()")
> > fixed a refcount leak bug in bind/connect but introduced a
> > use-after-free if the same local is assigned to 2 different sockets.
> >
> > This can be triggered by the following simple program:
> > int sock1 = socket( AF_NFC, SOCK_STREAM, NFC_SOCKPROTO_LLCP );
> > int sock2 = socket( AF_NFC, SOCK_STREAM, NFC_SOCKPROTO_LLCP );
> > memset( &addr, 0, sizeof(struct sockaddr_nfc_llcp) );
> > addr.sa_family = AF_NFC;
> > addr.nfc_protocol = NFC_PROTO_NFC_DEP;
> > bind( sock1, (struct sockaddr*) &addr, sizeof(struct sockaddr_nfc_llcp) )
> > bind( sock2, (struct sockaddr*) &addr, sizeof(struct sockaddr_nfc_llcp) )
> > close(sock1);
> > close(sock2);
> >
> > [...]
>
> Here is the summary with links:
> - net/nfc: fix use-after-free llcp_sock_bind/connect
> https://git.kernel.org/netdev/net/c/c61760e6940d
Dave,
Can you please share your thoughts how this patch can be correct?
https://lore.kernel.org/netdev/YJIjN6MTRdQ7Bvcp@unreal/T/#m1e67ae6c2658312a134f65819c5ad92511f207c1
It is also under review, so unclear why it was merged.
Thanks
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
>
next prev parent reply other threads:[~2021-05-05 4:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 7:16 [PATCH] net/nfc: fix use-after-free llcp_sock_bind/connect Or Cohen
2021-05-04 19:10 ` patchwork-bot+netdevbpf
2021-05-05 4:50 ` Leon Romanovsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-04 7:15 Or Cohen
2021-05-04 8:12 ` Leon Romanovsky
2021-05-04 16:01 ` Or Cohen
2021-05-05 4:46 ` Leon Romanovsky
[not found] ` <CABV_C9OJ6v1deEknc+V3cJaT+CPjmzg6Wb06_Rsey3AXqOBNYg@mail.gmail.com>
2021-05-05 11:30 ` Nadav Markus
2021-05-05 11:39 ` Leon Romanovsky
[not found] ` <CABV_C9PscjqNPTbK0JuNGsgCAX-xYg9=GG1KNyOh3hQU1TuzWQ@mail.gmail.com>
2021-05-05 14:17 ` Leon Romanovsky
2021-05-05 14:31 ` Or Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJIkBH/9kb6SMRh/@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=nmarkus@paloaltonetworks.com \
--cc=orcohen@paloaltonetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).