From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D556C48BCD for ; Wed, 9 Jun 2021 17:59:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27EBB613D4 for ; Wed, 9 Jun 2021 17:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231955AbhFISBP (ORCPT ); Wed, 9 Jun 2021 14:01:15 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54499 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231745AbhFISBP (ORCPT ); Wed, 9 Jun 2021 14:01:15 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C8BA65C0081; Wed, 9 Jun 2021 13:59:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 09 Jun 2021 13:59:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OyS7nl xq1SYrw+WUKc0O0Z4A8OI01bK+rJe/uwjy9aU=; b=kOdPYrnJnJtiC+tiydMCSp HzwLN/J9FhhiCEYehQQ4qh9YySLYQrYZNTz99iF187MD1Y6eGuWkkx7HYoOEDiMn uT3596NupWYC47HZ8gez3ofVUnitMxMe+LH2yIaixuwCYyW7SdeNSxtWxHYWfNzZ IWSReWtD6FuwoThv5XI/Yyuo6ynNoJwFyYUlEmhC7Lzzx9JvEk0uaLZaR7SvYQjO bMY/ugpE1Jgwc77WxTMx21InlfXOCk6i2NkJTupGi+8VemmQPk47xchMCSBksTQM xnN8z224OSJrtSGgDHErn4gpeH2ZAC6Xm4W3rqVFaHZt+gDwFatinT4Em1RAtLwg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeduuddguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudeh leetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Jun 2021 13:59:18 -0400 (EDT) Date: Wed, 9 Jun 2021 20:59:14 +0300 From: Ido Schimmel To: Oleksandr Mazur Cc: jiri@nvidia.com, davem@davemloft.net, kuba@kernel.org, Vadym Kochan , Taras Chornyi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nikolay@nvidia.com, roopa@nvidia.com Subject: Re: [PATCH net-next 10/11] net: marvell: prestera: add storm control (rate limiter) implementation Message-ID: References: <20210609151602.29004-1-oleksandr.mazur@plvision.eu> <20210609151602.29004-11-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609151602.29004-11-oleksandr.mazur@plvision.eu> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jun 09, 2021 at 06:16:00PM +0300, Oleksandr Mazur wrote: > Storm control (BUM) provides a mechanism to limit rate of ingress > port traffic (matched by type). Devlink port parameter API is used: > driver registers a set of per-port parameters that can be accessed to both > get/set per-port per-type rate limit. > Add new FW command - RATE_LIMIT_MODE_SET. This should be properly modeled in the bridge driver and offloaded to capable drivers via switchdev. Modeling it as a driver-specific devlink parameter is wrong.