From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel@pengutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Michael Grzeschik <m.grzeschik@pengutronix.de>
Subject: Re: [PATCH net-next v4 9/9] net: phy: micrel: ksz886x/ksz8081: add cabletest support
Date: Sat, 12 Jun 2021 20:23:53 +0200 [thread overview]
Message-ID: <YMT7uSNXBA8/2r8C@lunn.ch> (raw)
In-Reply-To: <20210611071527.9333-10-o.rempel@pengutronix.de>
> +static int ksz886x_cable_test_get_status(struct phy_device *phydev,
> + bool *finished)
> +{
> + unsigned long pair_mask = 0x3;
> + int retries = 20;
> + int pair, ret;
> +
> + *finished = false;
> +
> + /* Try harder if link partner is active */
> + while (pair_mask && retries--) {
> + for_each_set_bit(pair, &pair_mask, 4) {
> + ret = ksz886x_cable_test_one_pair(phydev, pair);
> + if (ret == -EAGAIN)
> + continue;
> + if (ret < 0)
> + return ret;
> + clear_bit(pair, &pair_mask);
> + }
> + /* If link partner is in autonegotiation mode it will send 2ms
> + * of FLPs with at least 6ms of silence.
> + * Add 2ms sleep to have better chances to hit this silence.
> + */
> + if (pair_mask)
> + msleep(2);
> + }
> +
> + *finished = true;
> +
> + return 0;
If ksz886x_cable_test_one_pair() returns -EAGAIN 20x and it gives up,
you end up returning 0. Maybe it would be better to return ret?
Andrew
next prev parent reply other threads:[~2021-06-12 18:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 7:15 [PATCH net-next v4 0/9] provide cable test support for the ksz886x switch Oleksij Rempel
2021-06-11 7:15 ` [PATCH net-next v4 1/9] net: phy: micrel: move phy reg offsets to common header Oleksij Rempel
2021-06-11 19:09 ` Vladimir Oltean
2021-06-11 23:27 ` Florian Fainelli
2021-06-11 7:15 ` [PATCH net-next v4 2/9] net: dsa: microchip: ksz8795: add phylink support Oleksij Rempel
2021-06-11 19:11 ` Vladimir Oltean
2021-06-11 23:28 ` Florian Fainelli
2021-06-11 7:15 ` [PATCH net-next v4 3/9] net: phy: micrel: use consistent alignments Oleksij Rempel
2021-06-11 19:12 ` Vladimir Oltean
2021-06-11 23:28 ` Florian Fainelli
2021-06-11 7:15 ` [PATCH net-next v4 4/9] net: phy: micrel: apply resume errata workaround for ksz8873 and ksz8863 Oleksij Rempel
2021-06-11 19:20 ` Vladimir Oltean
2021-06-12 4:26 ` Oleksij Rempel
2021-06-12 15:13 ` Vladimir Oltean
2021-06-14 6:55 ` Oleksij Rempel
2021-06-11 7:15 ` [PATCH net-next v4 5/9] net: phy/dsa micrel/ksz886x add MDI-X support Oleksij Rempel
2021-06-12 18:14 ` Andrew Lunn
2021-06-13 2:05 ` Florian Fainelli
2021-06-11 7:15 ` [PATCH net-next v4 6/9] net: phy: micrel: ksz8081 " Oleksij Rempel
2021-06-12 18:14 ` Andrew Lunn
2021-06-13 2:05 ` Florian Fainelli
2021-06-11 7:15 ` [PATCH net-next v4 7/9] net: dsa: microchip: ksz8795: add LINK_MD register support Oleksij Rempel
2021-06-12 18:16 ` Andrew Lunn
2021-06-13 2:09 ` Florian Fainelli
2021-06-11 7:15 ` [PATCH net-next v4 8/9] net: dsa: dsa_slave_phy_connect(): extend phy's flags with port specific phy flags Oleksij Rempel
2021-06-11 19:24 ` Vladimir Oltean
2021-06-11 23:26 ` Florian Fainelli
2021-06-14 3:37 ` Oleksij Rempel
2021-06-14 3:34 ` Oleksij Rempel
2021-06-11 7:15 ` [PATCH net-next v4 9/9] net: phy: micrel: ksz886x/ksz8081: add cabletest support Oleksij Rempel
2021-06-12 18:23 ` Andrew Lunn [this message]
2021-06-14 3:51 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMT7uSNXBA8/2r8C@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).