From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 870BFC48BE8 for ; Mon, 14 Jun 2021 02:11:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5552E6128B for ; Mon, 14 Jun 2021 02:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232322AbhFNCNs (ORCPT ); Sun, 13 Jun 2021 22:13:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232269AbhFNCNr (ORCPT ); Sun, 13 Jun 2021 22:13:47 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB9FAC061574; Sun, 13 Jun 2021 19:11:31 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id w4so12266674qvr.11; Sun, 13 Jun 2021 19:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=/pYpS7z9b3a/6qRwLgr21klDpDKmQtlWnOviQqkYZ5Y=; b=MXFiXfB//FGQvrfCVcyKi13yZLX8QO3gQ1Fs8a+3hEVU+pqPP7gM0F8+tFH0i61t1z a9OS7MAgUfMo4ti4QzqUs8m63FSCEYOHEZwTPrZuk+0nbW9/lwXyelMxcwzXsznBm0ge /FJ3NDdxgT5PHQggefPEe0VId1ROWsP28XLOLKyyf5LfECNU5eIFfetf4GaWNjxxREN6 wfPWARvyXRWxNYkSzTCWhzsEQHquYAsoMqeljVSo6At7Zuhk0J584TDYFA0sMaRH9ZOT ChHz4ax7eCED4sgUbe8AQKUtUpKngCIuYB0UdKqj4ghFpzesfNw3YbINupGepEBWOPqf FPZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=/pYpS7z9b3a/6qRwLgr21klDpDKmQtlWnOviQqkYZ5Y=; b=r8CzcGkDL+ZIegGygQty0QAxUidHj0eoKiVERaEOCZoP+cqR/MhVFtOx5UJdGuiq7C 6+/KoPXAgNv8QdWD5pq+lNGcu4NCzRsHwXeo9u6k/9ehP0dDiM4oCXPUZ8TcEpqGgRuR Kux0mVGjWXY4tZsVVM+fQZeDRdav0N/tEy+NGM7ScDOIs9amIvLL5MRyeiI8wPskcnOr q8oWn4CuQ2URbJTibffvFzaBmLu36j+M6xF6GpjHDN6GyisR3OAwBB/3PhwgEP+KA+Ng ZYMyu4NA1TVgNChi9b0E0smSUyJqnZq+2EFhkpFWomCmEKPmrwa1mINxgs2ZTFrT80bQ cmTA== X-Gm-Message-State: AOAM533lbZ5PvV713QgGLE2Ggeo2r+bH3vVk2Ww+fraqaXsqzSuiq1BY TmWfzT/RnZ0OKvYVjm7JYy16rnvsYFR+6zyxRb4= X-Google-Smtp-Source: ABdhPJwxRYJeq9Jsx574+RgiHVOKhUsOAnplR8AyrKgoOtsl57ncyd0oeoda6WAU93g3Y6VdAofllw== X-Received: by 2002:a0c:9e68:: with SMTP id z40mr16402873qve.17.1623636691013; Sun, 13 Jun 2021 19:11:31 -0700 (PDT) Received: from tobias-VirtualBox (ool-18ba8988.dyn.optonline.net. [24.186.137.136]) by smtp.gmail.com with ESMTPSA id o5sm8747078qta.51.2021.06.13.19.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jun 2021 19:11:30 -0700 (PDT) Date: Sun, 13 Jun 2021 22:11:30 -0400 From: Tobias Alam To: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Coiby Xu , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: qlge: change msleep to usleep_range Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch changes msleep() to usleep_range() based on Documentation/timers/timers-howto.txt. It suggests using usleep_range() for small msec(1ms - 20ms) because msleep() will often sleep longer than the desired value. Issue found by checkpatch. Signed-off-by: Tobias Alam --- drivers/staging/qlge/qlge_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c index b70570b7b467..87d60115ac67 100644 --- a/drivers/staging/qlge/qlge_ethtool.c +++ b/drivers/staging/qlge/qlge_ethtool.c @@ -553,7 +553,7 @@ static int qlge_run_loopback_test(struct qlge_adapter *qdev) atomic_inc(&qdev->lb_count); } /* Give queue time to settle before testing results. */ - msleep(2); + usleep_range(2000, 2100); qlge_clean_lb_rx_ring(&qdev->rx_ring[0], 128); return atomic_read(&qdev->lb_count) ? -EIO : 0; } -- 2.30.2