From: Christoph Hellwig <hch@infradead.org>
To: Dongdong Liu <liudongdong3@huawei.com>
Cc: helgaas@kernel.org, hch@infradead.org, kw@linux.com,
linux-pci@vger.kernel.org, rajur@chelsio.com,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RESEND PATCH V3 4/6] PCI: Enable 10-Bit tag support for PCIe Endpoint devices
Date: Mon, 14 Jun 2021 06:54:33 +0100 [thread overview]
Message-ID: <YMbvGYR/pAMwKMbB@infradead.org> (raw)
In-Reply-To: <1623576555-40338-5-git-send-email-liudongdong3@huawei.com>
On Sun, Jun 13, 2021 at 05:29:13PM +0800, Dongdong Liu wrote:
> +static void pci_configure_10bit_tags(struct pci_dev *dev)
> +{
> + struct pci_dev *bridge;
> +
> + if (!pci_is_pcie(dev))
> + return;
> +
> + if (!(dev->pcie_devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_COMP))
> + return;
Doesn't the second check imply the first one?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-06-14 5:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 9:29 [RESEND PATCH V3 0/6] PCI: Enable 10-Bit tag support for PCIe devices Dongdong Liu
2021-06-13 9:29 ` [RESEND PATCH V3 1/6] PCI: Use cached Device Capabilities Register Dongdong Liu
2021-06-14 5:42 ` Christoph Hellwig
2021-06-15 3:03 ` Dongdong Liu
2021-06-18 14:51 ` kernel test robot
2021-06-21 7:18 ` Dongdong Liu
2021-06-13 9:29 ` [RESEND PATCH V3 2/6] PCI: Use cached Device Capabilities 2 Register Dongdong Liu
2021-06-14 5:49 ` Christoph Hellwig
2021-06-15 3:04 ` Dongdong Liu
2021-06-13 9:29 ` [RESEND PATCH V3 3/6] PCI: Add 10-Bit Tag register definitions Dongdong Liu
2021-06-14 5:50 ` Christoph Hellwig
2021-06-13 9:29 ` [RESEND PATCH V3 4/6] PCI: Enable 10-Bit tag support for PCIe Endpoint devices Dongdong Liu
2021-06-14 5:54 ` Christoph Hellwig [this message]
2021-06-15 3:07 ` Dongdong Liu
2021-06-13 9:29 ` [RESEND PATCH V3 5/6] PCI/IOV: Enable 10-Bit tag support for PCIe VF devices Dongdong Liu
2021-06-14 5:55 ` Christoph Hellwig
2021-06-13 9:29 ` [RESEND PATCH V3 6/6] PCI: Enable 10-Bit tag support for PCIe RP devices Dongdong Liu
2021-06-14 5:57 ` Christoph Hellwig
2021-06-15 3:08 ` Dongdong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMbvGYR/pAMwKMbB@infradead.org \
--to=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kw@linux.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).