From: andy@surfacebook.localdomain
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, hkallweit1@gmail.com,
netdev@vger.kernel.org, Grant Likely <grant.likely@arm.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
calvin.johnson@oss.nxp.com,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
linux-arm-kernel@lists.infradead.org,
Diana Madalina Craciun <diana.craciun@nxp.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux.cj@gmail.com, Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Len Brown <lenb@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next v9 08/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy()
Date: Tue, 15 Jun 2021 23:15:57 +0300 [thread overview]
Message-ID: <YMkKfUhT6BQ1od5B@surfacebook.localdomain> (raw)
In-Reply-To: <20210611105401.270673-9-ciorneiioana@gmail.com>
Fri, Jun 11, 2021 at 01:53:54PM +0300, Ioana Ciornei kirjoitti:
> From: Calvin Johnson <calvin.johnson@oss.nxp.com>
>
> Introduce fwnode_mdiobus_register_phy() to register PHYs on the
> mdiobus. From the compatible string, identify whether the PHY is
> c45 and based on this create a PHY device instance which is
> registered on the mdiobus.
>
> Along with fwnode_mdiobus_register_phy() also introduce
> fwnode_find_mii_timestamper() and fwnode_mdiobus_phy_device_register()
> since they are needed.
> While at it, also use the newly introduced fwnode operation in
> of_mdiobus_phy_device_register().
I understand that this patch series is applied, but I think we have a problem
that has to be fixed before the release. See below for the details.
...
> +int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
> + struct phy_device *phy,
> + struct fwnode_handle *child, u32 addr)
> +{
> + int rc;
> +
> + rc = fwnode_irq_get(child, 0);
> + if (rc == -EPROBE_DEFER)
> + return rc;
> +
> + if (rc > 0) {
> + phy->irq = rc;
> + mdio->irq[addr] = rc;
> + } else {
> + phy->irq = mdio->irq[addr];
> + }
> +
> + if (fwnode_property_read_bool(child, "broken-turn-around"))
> + mdio->phy_ignore_ta_mask |= 1 << addr;
> +
> + fwnode_property_read_u32(child, "reset-assert-us",
> + &phy->mdio.reset_assert_delay);
> + fwnode_property_read_u32(child, "reset-deassert-us",
> + &phy->mdio.reset_deassert_delay);
> +
> + /* Associate the fwnode with the device structure so it
> + * can be looked up later
> + */
> + fwnode_handle_get(child);
We take a reference counting here.
Who and when should drop it?
> + phy->mdio.dev.fwnode = child;
> +
> + /* All data is now stored in the phy struct;
> + * register it
> + */
> + rc = phy_device_register(phy);
> + if (rc) {
> + fwnode_handle_put(child);
> + return rc;
> + }
> +
> + dev_dbg(&mdio->dev, "registered phy %p fwnode at address %i\n",
> + child, addr);
> + return 0;
> +}
> +EXPORT_SYMBOL(fwnode_mdiobus_phy_device_register);
> +
> +int fwnode_mdiobus_register_phy(struct mii_bus *bus,
> + struct fwnode_handle *child, u32 addr)
> +{
> + struct mii_timestamper *mii_ts = NULL;
> + struct phy_device *phy;
> + bool is_c45 = false;
> + u32 phy_id;
> + int rc;
> +
> + mii_ts = fwnode_find_mii_timestamper(child);
> + if (IS_ERR(mii_ts))
> + return PTR_ERR(mii_ts);
> +
> + rc = fwnode_property_match_string(child, "compatible",
> + "ethernet-phy-ieee802.3-c45");
> + if (rc >= 0)
> + is_c45 = true;
> +
> + if (is_c45 || fwnode_get_phy_id(child, &phy_id))
> + phy = get_phy_device(bus, addr, is_c45);
> + else
> + phy = phy_device_create(bus, addr, phy_id, 0, NULL);
> + if (IS_ERR(phy)) {
> + unregister_mii_timestamper(mii_ts);
> + return PTR_ERR(phy);
> + }
> +
> + if (is_acpi_node(child)) {
> + phy->irq = bus->irq[addr];
> +
> + /* Associate the fwnode with the device structure so it
> + * can be looked up later.
> + */
> + phy->mdio.dev.fwnode = child;
> +
> + /* All data is now stored in the phy struct, so register it */
> + rc = phy_device_register(phy);
> + if (rc) {
> + phy_device_free(phy);
> + fwnode_handle_put(phy->mdio.dev.fwnode);
We dropped reference counting here, but who and when acquired it?
> + return rc;
> + }
> + } else if (is_of_node(child)) {
> + rc = fwnode_mdiobus_phy_device_register(bus, phy, child, addr);
> + if (rc) {
> + unregister_mii_timestamper(mii_ts);
> + phy_device_free(phy);
> + return rc;
> + }
> + }
> +
> + /* phy->mii_ts may already be defined by the PHY driver. A
> + * mii_timestamper probed via the device tree will still have
> + * precedence.
> + */
> + if (mii_ts)
> + phy->mii_ts = mii_ts;
> + return 0;
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-15 20:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 10:53 [PATCH net-next v9 00/15] ACPI support for dpaa2 driver Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 01/15] Documentation: ACPI: DSD: Document MDIO PHY Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 02/15] net: phy: Introduce fwnode_mdio_find_device() Ioana Ciornei
2021-06-11 11:20 ` Andy Shevchenko
2021-06-11 10:53 ` [PATCH net-next v9 03/15] net: phy: Introduce phy related fwnode functions Ioana Ciornei
2021-06-11 11:26 ` Andy Shevchenko
2021-06-11 11:40 ` Rafael J. Wysocki
2021-06-11 12:08 ` Russell King (Oracle)
2021-06-11 12:31 ` Rafael J. Wysocki
2021-06-11 10:53 ` [PATCH net-next v9 04/15] of: mdio: Refactor of_phy_find_device() Ioana Ciornei
2021-06-11 11:28 ` Andy Shevchenko
2021-06-11 11:30 ` Andy Shevchenko
2021-06-11 11:35 ` Russell King (Oracle)
2021-06-11 10:53 ` [PATCH net-next v9 05/15] net: phy: Introduce fwnode_get_phy_id() Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 06/15] of: mdio: Refactor of_get_phy_id() Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 07/15] net: mii_timestamper: check NULL in unregister_mii_timestamper() Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 08/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Ioana Ciornei
2021-06-15 20:15 ` andy [this message]
2021-06-11 10:53 ` [PATCH net-next v9 09/15] of: mdio: Refactor of_mdiobus_register_phy() Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 10/15] ACPI: utils: Introduce acpi_get_local_address() Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 11/15] net: mdio: Add ACPI support code for mdio Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 12/15] net/fsl: Use [acpi|of]_mdiobus_register Ioana Ciornei
2021-06-11 10:53 ` [PATCH net-next v9 13/15] net: phylink: introduce phylink_fwnode_phy_connect() Ioana Ciornei
2021-06-11 11:17 ` Russell King (Oracle)
2021-06-15 20:18 ` andy
2021-06-11 10:54 ` [PATCH net-next v9 14/15] net: phylink: Refactor phylink_of_phy_connect() Ioana Ciornei
2021-06-11 11:18 ` Russell King (Oracle)
2021-06-11 10:54 ` [PATCH net-next v9 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Ioana Ciornei
2021-06-11 20:20 ` [PATCH net-next v9 00/15] ACPI support for dpaa2 driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMkKfUhT6BQ1od5B@surfacebook.localdomain \
--to=andy@surfacebook.localdomain \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=ciorneiioana@gmail.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=grant.likely@arm.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=kuba@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pieter.jansenvv@bamboosystems.io \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).