From: Andrew Lunn <andrew@lunn.ch>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
pablo@netfilter.org, ryder.lee@mediatek.com
Subject: Re: [RFC 2/7] net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)
Date: Tue, 13 Jul 2021 20:31:58 +0200 [thread overview]
Message-ID: <YO3cHoEGwzpWDxnI@lunn.ch> (raw)
In-Reply-To: <20210713160745.59707-3-nbd@nbd.name>
> diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c
> +
> +static inline void
> +wed_m32(struct mtk_wed_device *dev, u32 reg, u32 mask, u32 val)
> +{
> + regmap_update_bits(dev->hw->regs, reg, mask | val, val);
> +}
Please don't use inline functions in .c files. Let the compiler
decide.
> +static void
> +mtk_wed_reset(struct mtk_wed_device *dev, u32 mask)
> +{
> + int i;
> +
> + wed_w32(dev, MTK_WED_RESET, mask);
> + for (i = 0; i < 100; i++) {
> + if (wed_r32(dev, MTK_WED_RESET) & mask)
> + continue;
> +
> + return;
> + }
It may be better to use something from iopoll.h
> +static inline int
> +mtk_wed_device_attach(struct mtk_wed_device *dev)
> +{
> + int ret = -ENODEV;
> +
> +#ifdef CONFIG_NET_MEDIATEK_SOC_WED
if (IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED) is better, since it
compiles the code, and then the optimizer throws away.
> + rcu_read_lock();
> + dev->ops = rcu_dereference(mtk_soc_wed_ops);
> + if (dev->ops)
> + ret = dev->ops->attach(dev);
> + rcu_read_unlock();
> +
> + if (ret)
> + dev->ops = NULL;
> +#endif
> +
> + return ret;
> +}
Andrew
next prev parent reply other threads:[~2021-07-13 18:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 16:07 [RFC 0/7] Ethernet->WLAN hardware flow offloading support on MT7622 Felix Fietkau
2021-07-13 16:07 ` [RFC 1/7] mac80211: add support for .ndo_fill_forward_path Felix Fietkau
2021-07-13 16:46 ` Johannes Berg
2021-07-13 16:07 ` [RFC 2/7] net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED) Felix Fietkau
2021-07-13 18:31 ` Andrew Lunn [this message]
2021-07-14 8:03 ` Felix Fietkau
2021-07-13 16:07 ` [RFC 3/7] net: ethernet: mtk_eth_soc: implement flow offloading to WED devices Felix Fietkau
2021-07-13 18:40 ` Pablo Neira Ayuso
2021-07-14 8:21 ` Felix Fietkau
2021-07-13 18:56 ` Pablo Neira Ayuso
2021-07-14 8:26 ` Felix Fietkau
2021-07-15 21:36 ` Pablo Neira Ayuso
2021-07-16 6:09 ` Felix Fietkau
2021-07-13 16:07 ` [RFC 4/7] mt76: dma: add wrapper macro for accessing queue registers Felix Fietkau
2021-07-13 16:07 ` [RFC 5/7] mt76: make number of tokens configurable dynamically Felix Fietkau
2021-07-13 16:07 ` [RFC 6/7] mt76: mt7915: remove irq parameter from mt7915_mmio_init Felix Fietkau
2021-07-13 16:07 ` [RFC 7/7] mt76: mt7915: add Wireless Ethernet Dispatch support Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO3cHoEGwzpWDxnI@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).