From: Andrew Lunn <andrew@lunn.ch>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sergey Shtylyov <s.shtylyov@omprussia.ru>,
Adam Ford <aford173@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
Yuusuke Ashizuka <ashiduka@fujitsu.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH/RFC 1/2] ravb: Preparation for supporting Gigabit Ethernet driver
Date: Wed, 14 Jul 2021 17:39:07 +0200 [thread overview]
Message-ID: <YO8FG0zJoG3GI9S9@lunn.ch> (raw)
In-Reply-To: <20210714145408.4382-2-biju.das.jz@bp.renesas.com>
On Wed, Jul 14, 2021 at 03:54:07PM +0100, Biju Das wrote:
> The DMAC and EMAC blocks of Gigabit Ethernet IP is almost
> similar to Ethernet AVB. With few canges in driver we can
changes
> support both the IP. This patch is in preparation for
> supporting the same.
Please break this up a bit, it is hard to review. You can put all the
refactoring into helpers into one patch. But changes like
> - if (priv->chip_id == RCAR_GEN2) {
> + if (priv->chip_id != RCAR_GEN3) {
should be in a seperate patch with an explanation.
You are aiming for lots of very simple patches which are obviously
correct.
> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
> index 86a1eb0634e8..80e62ca2e3d3 100644
> --- a/drivers/net/ethernet/renesas/ravb.h
> +++ b/drivers/net/ethernet/renesas/ravb.h
> @@ -864,7 +864,7 @@ enum GECMR_BIT {
>
> /* The Ethernet AVB descriptor definitions. */
> struct ravb_desc {
> - __le16 ds; /* Descriptor size */
> + __le16 ds; /* Descriptor size */
> u8 cc; /* Content control MSBs (reserved) */
> u8 die_dt; /* Descriptor interrupt enable and type */
> __le32 dptr; /* Descriptor pointer */
Please put white spaces changes in a patch of its own.
Andrew
next prev parent reply other threads:[~2021-07-14 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 14:54 [PATCH/RFC 0/2] Add Gigabit Ethernet driver support Biju Das
2021-07-14 14:54 ` [PATCH/RFC 1/2] ravb: Preparation for supporting Gigabit Ethernet driver Biju Das
2021-07-14 15:39 ` Andrew Lunn [this message]
2021-07-14 16:24 ` Biju Das
2021-07-14 18:20 ` Sergei Shtylyov
2021-07-15 6:49 ` Biju Das
2021-07-14 14:54 ` [PATCH/RFC 2/2] ravb: Add GbEthernet driver support Biju Das
2021-07-14 16:02 ` Andrew Lunn
2021-07-14 17:01 ` Biju Das
2021-07-14 17:25 ` Andrew Lunn
2021-07-14 17:56 ` Biju Das
2021-07-15 10:13 ` Geert Uytterhoeven
2021-07-15 10:31 ` Biju Das
2021-07-19 20:41 ` Sergei Shtylyov
2021-07-20 6:32 ` Biju Das
2021-07-14 19:26 ` [PATCH/RFC 0/2] Add Gigabit Ethernet " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO8FG0zJoG3GI9S9@lunn.ch \
--to=andrew@lunn.ch \
--cc=Chris.Paterson2@renesas.com \
--cc=aford173@gmail.com \
--cc=andrew_gabbasov@mentor.com \
--cc=ashiduka@fujitsu.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.shtylyov@omprussia.ru \
--cc=sergei.shtylyov@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).