From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B476FC12002
	for <netdev@archiver.kernel.org>; Wed, 14 Jul 2021 20:26:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 964C961260
	for <netdev@archiver.kernel.org>; Wed, 14 Jul 2021 20:26:32 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230004AbhGNU3X (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 14 Jul 2021 16:29:23 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:55344 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230314AbhGNU3G (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 14 Jul 2021 16:29:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=RJX5MkYYxa5x+XDN3B7Fffz0vmZrTXCXZXE3bdoR+hs=; b=BkU6f3p+HGW/uMmhDapfTbMjQR
        90FJj7qBL96fHychYwKTzkfq6brFpqxESZCxLRRxBdYq+pm/L6RpDKjmAxZ0iBIhBP8ln/LRHLSsp
        1Peg6Q4osHE/VOCXbe2KKssge+Bd9ujaNb/JWe2EF8FIb3sBC+A5jXhexKNc4i9d62JU=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1m3lS1-00DOaq-C6; Wed, 14 Jul 2021 22:25:49 +0200
Date:   Wed, 14 Jul 2021 22:25:49 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Jacob Keller <jacob.e.keller@intel.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kubakici@wp.pl>,
        Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next RFC] devlink: add commands to query flash and
 reload support
Message-ID: <YO9ITZknrXte6jpB@lunn.ch>
References: <20210714193918.1151083-1-jacob.e.keller@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210714193918.1151083-1-jacob.e.keller@intel.com>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> I'm not sure if this is the best direction to go for implementing this.

Hi Jacob

Maybe add a --dry-run option? That would allow the driver to also read
the firmware file, make sure it can parse it, it fits the actual
hardware, and the CRC is O.K, etc.

We just need to make sure that if it fails with -EOPNOTSUPP, is it
clear if --dry-run itself is not supported, or the operation is not
supported. extack should help with that.

	   Andrew