From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
sasha.neftin@intel.com, vitaly.lifshits@intel.com,
vinicius.gomes@intel.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
Subject: Re: [PATCH net-next 5/5] igc: Export LEDs
Date: Mon, 19 Jul 2021 00:33:44 +0200 [thread overview]
Message-ID: <YPSsSL32QNBnx0xc@lunn.ch> (raw)
In-Reply-To: <f42099b8-5ba3-3514-e5fa-8d1be37192b5@gmail.com>
On Mon, Jul 19, 2021 at 12:10:52AM +0200, Heiner Kallweit wrote:
> On 16.07.2021 23:56, Andrew Lunn wrote:
> > On Fri, Jul 16, 2021 at 02:24:27PM -0700, Tony Nguyen wrote:
> >> From: Kurt Kanzenbach <kurt@linutronix.de>
> >>
> >> Each i225 has three LEDs. Export them via the LED class framework.
> >>
> >> Each LED is controllable via sysfs. Example:
> >>
> >> $ cd /sys/class/leds/igc_led0
> >> $ cat brightness # Current Mode
> >> $ cat max_brightness # 15
> >> $ echo 0 > brightness # Mode 0
> >> $ echo 1 > brightness # Mode 1
> >>
> >> The brightness field here reflects the different LED modes ranging
> >> from 0 to 15.
> >
> > What do you mean by mode? Do you mean blink mode? Like On means 1G
> > link, and it blinks for packet TX?
> >
> Supposedly mode refers to a 4-bit bitfield in a LED control register
> where each value 0 .. 15 stands for a different blink mode.
> So you would need the datasheet to know which value to set.
If the brightness is being abused to represent the blink mode, this
patch is going to get my NACK. Unfortunately, i cannot find a
datasheet for this chip to know what the LED control register actually
does. So i'm waiting for a reply to my question.
There is a broad agreement between the LED maintainers and the PHYLIB
maintainers how Ethernet LEDs should be described with the hardware
blinking the LED for different reasons. The LED trigger mechanisms
should be used, one trigger per mode, and the trigger is then
offloaded to the hardware.
Andrew
next prev parent reply other threads:[~2021-07-18 22:33 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 21:24 [PATCH net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2021-07-16 Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 1/5] igc: Add possibility to add flex filter Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 2/5] igc: Integrate flex filter into ethtool ops Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 3/5] igc: Allow for Flex Filters to be installed Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 4/5] igc: Make flex filter more flexible Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 5/5] igc: Export LEDs Tony Nguyen
2021-07-16 21:56 ` Andrew Lunn
2021-07-18 22:10 ` Heiner Kallweit
2021-07-18 22:33 ` Andrew Lunn [this message]
2021-07-19 6:17 ` Kurt Kanzenbach
2021-07-19 9:46 ` Jakub Kicinski
2021-07-19 6:06 ` Kurt Kanzenbach
2021-07-19 13:15 ` Andrew Lunn
2021-07-20 8:54 ` Kurt Kanzenbach
2021-07-21 19:18 ` Marek Behún
2021-07-18 22:19 ` Heiner Kallweit
2021-07-19 0:40 ` Andrew Lunn
2021-07-20 15:00 ` Heiner Kallweit
2021-07-20 15:42 ` Andrew Lunn
2021-07-20 20:29 ` Heiner Kallweit
2021-07-21 14:35 ` Andrew Lunn
2021-07-21 16:02 ` Heiner Kallweit
2021-07-21 18:23 ` Pavel Machek
2021-07-21 18:25 ` Pavel Machek
2021-07-21 18:45 ` Marek Behún
2021-07-21 19:50 ` Andrew Lunn
2021-07-21 20:07 ` Marek Behún
2021-07-21 20:54 ` Andrew Lunn
2021-07-21 21:31 ` Marek Behún
2021-07-21 22:45 ` Pavel Machek
2021-07-22 1:45 ` Andrew Lunn
2021-07-22 2:19 ` Marek Behún
2021-07-21 22:34 ` Pavel Machek
2021-07-22 3:52 ` Florian Fainelli
2021-07-26 17:42 ` Jacek Anaszewski
2021-07-26 18:44 ` Marek Behún
2021-07-26 20:59 ` Heiner Kallweit
2021-07-27 0:06 ` Marek Behún
2021-07-27 1:57 ` Andrew Lunn
2021-07-27 8:15 ` Michael Walle
2021-07-27 14:56 ` Marek Behún
2021-07-27 15:03 ` Michael Walle
2021-07-27 15:24 ` Andrew Lunn
2021-07-27 15:28 ` Marek Behún
2021-07-27 15:53 ` Michael Walle
2021-07-27 16:23 ` Andrew Lunn
2021-07-27 16:32 ` Marek Behún
2021-07-27 16:42 ` Andrew Lunn
2021-07-27 19:42 ` Michael Walle
2021-07-28 20:43 ` Heiner Kallweit
2021-07-29 6:39 ` Kurt Kanzenbach
2021-07-29 8:59 ` Marek Behún
2021-07-29 21:54 ` Heiner Kallweit
2021-08-10 17:29 ` Pavel Machek
2021-08-10 17:55 ` Marek Behún
2021-08-10 19:53 ` Pavel Machek
2021-08-10 20:53 ` Marek Behún
2021-08-17 19:02 ` Pavel Machek
2021-08-25 15:26 ` Marek Behún
2021-08-26 12:45 ` Pavel Machek
2021-08-10 20:46 ` Heiner Kallweit
2021-08-10 21:21 ` Andrew Lunn
2021-07-27 13:55 ` Marek Behún
2021-08-10 17:22 ` Documentation for naming LEDs was " Pavel Machek
2021-07-19 21:48 ` Jesse Brandeburg
2021-07-20 13:31 ` Kurt Kanzenbach
2021-07-17 0:30 ` [PATCH net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2021-07-16 patchwork-bot+netdevbpf
2021-07-17 17:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPSsSL32QNBnx0xc@lunn.ch \
--to=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dvorax.fuxbrumer@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).