From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2785FC4320A for ; Wed, 28 Jul 2021 13:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E96860EC0 for ; Wed, 28 Jul 2021 13:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236344AbhG1NrI (ORCPT ); Wed, 28 Jul 2021 09:47:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49812 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236691AbhG1NqW (ORCPT ); Wed, 28 Jul 2021 09:46:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=dJr5/InFEe21OM6ybxukBLEbeFlKPVFc6d3Sfz79n9w=; b=J9KE/1Irq3Z47wn2zFN2IGJnxx HZ+lx3rkUSB6A4HgfNCWE5atbzAMX1NucFsSSzPhllq4OETuFG7aIPwiTqtwL4Dmaw0ksW9KQ+FQB 5fHRjERE5c95IJ8iVCHX++E+0WXndYyslCJzTvO7COSm94EgsDV73/Nt5FU9cy/EOF4Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m8jsF-00FAt9-Ld; Wed, 28 Jul 2021 15:45:27 +0200 Date: Wed, 28 Jul 2021 15:45:27 +0200 From: Andrew Lunn To: Biju Das Cc: Sergei Shtylyov , "David S. Miller" , Jakub Kicinski , Geert Uytterhoeven , Sergey Shtylyov , Adam Ford , Yuusuke Ashizuka , Yoshihiro Shimoda , "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson , Biju Das , Prabhakar Mahadev Lad Subject: Re: [PATCH net-next 08/18] ravb: Add R-Car common features Message-ID: References: <20210722141351.13668-1-biju.das.jz@bp.renesas.com> <20210722141351.13668-9-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > > @@ -2205,8 +2235,10 @@ static int ravb_probe(struct platform_device > > *pdev) > > > } > > > clk_prepare_enable(priv->refclk); > > > > > > - ndev->max_mtu = 2048 - (ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN); > > > - ndev->min_mtu = ETH_MIN_MTU; > > > + if (info->features & RAVB_OVERRIDE_MTU_CHANGE) { > > > > Why? :-/ Could you tell me more details? > > RX buff size = 2048 for R-Car where as it is 8K for RZ/G2L. RAVB_OVERRIDE_MTU_CHANGE is not the most descriptive name. You are not overriding, you are setting the correct value for the hardware variant. Maybe name the feature RAVB_8K_BUFFERS or RAVB_2K_BUFFERS. Also, putting more details in the commit message will help, and lots of small patches, each patch doing one thing. It is much better to have 40 simple, well documented, obviously correct patches, than 20 hard to understand patches. But please do submit them in small batches, no more than 15 at once. Andrew